Just like it already does with Apache Solr, this module should use Search Lucene API/Content to search for nodes when available.

CommentFileSizeAuthor
#8 search404_luceneapi.patch1.04 KBWorldFallz
#1 search404.module.patch878 byteswimh

Comments

wimh’s picture

wimh commented
Status: Active » Needs review
StatusFileSize
new search404.module.patch878 bytes

Patch attached.

mfer’s picture

mfer commented

any movement on this?

wimh’s picture

wimh commented

I didn't hear any response from the module maintainers yet... But my patch is working for some time now on my production site, so go ahead and try it out!

Ela’s picture

Ela commented

Works great!!! Thank you for the patch!!! :)

bunker’s picture

bunker commented

this module sounds great, I'm using lucene api for search

when I try to patch I get the following error:

$ sudo patch < search404.module_4.patch
(Stripping trailing CRs from patch.)
patching file search404.module
Hunk #1 FAILED at 102.
1 out of 1 hunk FAILED -- saving rejects to file search404.module.rej

what should I do?

wimh’s picture

wimh commented

That patch is for the 6.x-1.8 version. Are you trying to apply it to the Drupal 5 version of the module by any chance? In any case, you can open the patch file with a text editor, have a look at what replacements it's supposed to do, and make the same changes by hand.

j0nathan’s picture

j0nathan commented

Hello and thank you for the module.
Is there any updates about the integration of the patch into the module?

WorldFallz’s picture

WorldFallz commented
StatusFileSize
new search404_luceneapi.patch1.04 KB

Here's an updated patch against the current 6.x dev version.

fragger_fox’s picture

fragger_fox commented

Thank you for the patch I will apply this in the latest dev version of 6.x

Regards
Santhosh N.Raju

zyxware’s picture

zyxware commented
Assigned: Unassigned » zyxware

I have updated the dev version of Search404 with this patch

Let me know if things are fine.

Regards
Santhosh Raju

j0nathan’s picture

j0nathan commented

Hi,
Version 6.x-1.x-dev (2010-Mar-22 ) gives me results with Lucene.
Thank you very much.

zyxware’s picture

zyxware commented
Status: Needs review » Fixed

Thanks for the update J0nathan

I am marking this issue as fixed

Regards
Santhosh Raju

WorldFallz’s picture

WorldFallz commented

Yep I just updated and it's working fine. thanks for committing this!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

mrgavindb’s picture

mrgavindb commented

Great fix! Works for me.

EDIT: I just noticed that version 1.9 offers this feature without making any code changes.

pixelsweatshop’s picture

pixelsweatshop commented

have I missed something? I have both installed and I do not see the option for using Lucene with this module. Or does it automatically use it?

wimh’s picture

wimh commented

have I missed something? I have both installed and I do not see the option for using Lucene with this module. Or does it automatically use it?

There is no configuration setting, it should just use Lucene automatically. (Unless you also have Apache SOLR installed, then that one takes precedence).

pixelsweatshop’s picture

pixelsweatshop commented

hmm. I don't have Solr installed, but the search through a 404 doesn't reveal the same results as a general search (using the same terms)