Port Volunteer to Drupal 4.7

Here we go. Rename this file to 'volunteer.install' and place it in your volunteer module directory. It should automatically create the tables for you when you enable the module.

Probably a 4.7 branch for now, I guess. I can talk w/ Steven next time I see him and ask if there's some alternate way we could tag it.

Here's an updated patch with what I have so far, which fixes a few more things. However, I'm completely and utterly stuck on the following in volunteer_volunteer_form:

$crm_form = crm_uf_get_profile_html( $userID, $title, $action, $register, $reset );
...
$form = $crm_form;

Obviously, forms are no longer HTML, so this won't work.

I tried the following:

$form['crm_form'] = array(
'#value' => $crm_form,
);

This works in that it displays the form, but doesn't in that you can't actually submit it at all (or you can, but it doesn't register anywhere).

I'm also getting two completely different outputs for ?q=volunteer/volunteer/1 on two servers. My CSL testbed provides three fields (without labels ;\), presumably for "first name," "last name," and "email (home)" as this would match what's in CivicSpace 0.8.4... my local testing server has a whole elaborate form with location information and "Most Important Issue Education Environment Social Justice" and stuff. Very bizarre. But at any rate, neither form is working, which makes this patch rather useless atm. :(

Any insight into how I could duplicate this behaviour in 4.7 would be greatly appreciated.

OK excellent. Thanks, killes.. I'll work with that.

Newest patch, still needs work though... ;(

Tried to go the route of creating dummy forms in 4.7, but the problem with that approach is that the form will change depending on what profile fields have been entered into CiviCRM. Instead, I tweaked the #value => $crn_form thing and think I got it working, although there are some other issues...

Also fixed some other misc. 4.6 => 4.7 things.

Ok here is an updated patch. not 100% perfect, as there are still things that could be FAPI-ized for maximum radness, but all the major areas seem to be functioning, so marking this up to "code needs review."

Summary of changes:

* Moved the "get all volunteer coordinators" stuff to a separate function, and updated the algorithm to not check the users_roles table since that no longer applies.
* Fixed a segfault error in PHP 5.1 w/ _volunteer_array_mergedown
* Fixed the WSODs on volunteer_question_coordinator()
* Fixed missing field labels on volunteer form (see .install file follow-up)
* Fixed rating form, and converted to validate/submit model
* Fixed some notices
* Added some PHP doc
* Fixed some minor whitespace stuff

KNOWN BUGS/TODOs:
- node/#/volunteer will not show first name/last name/email of volunteers. From reading the code, it appears that CiviCRM contacts used to be stored as arrays and now they are stored as objects. Therefore, when we do _volunteer_array_mergedown on the $contact array, these properties are still stuck in a CRM_Contact_BAO_Individual object under 'contact_type_object' so ['first_name'], ['last_name'], etc. do not exist. Need advice from someone who understands this module and CiviCRM better to know what to do here. (i.e. $civicrm_contact = $contact['contact_type_object']; ? will that work across CiviCRM versions?)

- I couldn't convert volunteer_volunteer or volunteer_volunteer_form to the validate/submit model, because their entire form is generated inside CiviCRM, and I've no idea how to tie into that from Drupal's Form API functions. ;(

- There are still a number of other validate/submit model translations I haven't had a chance to look at yet.

Anyway, please take a look and let me know what you think!

And here's the .install file. Apparently there is a known issue that field labels from 1.3 to 1.4 get lost? (Rob mentioned something about this). So I've included an update script which sets them explicitly.

Fixed the "node/#/volunteer will not show first name/last name/email of volunteers" problem. This stemmed from my consolidation of mergedown and array_walk_recphp4 functions; it was no longer actually merging down the array properties.

The solution? Forward-porting object2array. :( Not what I wanted to do, but casting $val to an array explicitly gets us back in segfault land under PHP 5.

Still some outstanding validate/submit module conversions, but I'm really tempted to just leave well enough alone for now, since the module seems to be working okay with the forms the way they are.

Would highly appreciate someone other than me testing the CVS version of volunteer w/ CiviCRM 1.4 and Drupal 4.7 to see if anything's blatantly missing/not working. :)

I've no idea. But as soon as I change:

$val = _volunteer_object2array($val);

to:

$val = (array)$val;

We're in "Your connection has been reset" land. ;( Maybe because the $val object is about 4-5 levels deep in some places?