Missing translations in Adsense module (but they are 'there')
| Project: | AdSense |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | postponed (maintainer needs more info) |
Hi, folks
I don't know if this is something due to the Adsense module itself, to the localization server or to the interaction of both of them.
I am translating into Spanish the Adsense module with the localization server to use it in one of my sites (6.x-1.2). I have translated a bunch of sections called 'Help and instructions'. The localization server reports this content to be part of AdSense: 5.x-1.6, though it is as well used in Adsense 6.x-1.2.
So, when exporting the po file to inject it into a site (Drupal 6.14 wholly up-to-date), it does not get this translations (and some others) because they are not included into the po file.
I guess this is so because the server understands them outside the 6.x-1.2 branch. But they are 6!
As a sidenote, I must say this text strings are not included in any po file that I try to generate myself to make a template to build the po file from the site the 'traditional' way.
So, I am not sure about the reason of this and wether it is something localization server-related. Should I report this as an issue in the module page?
Thanks
#1
Can you provide some concrete examples?
#2
Yes, Gabor, of course:
In the page /admin/settings/adsense of a Drupal 6.14 site with Adsense, there is /admin/settings/adsense#, where you have some parts with h2 and h3 headings like:
<h2>Overview</h2>
<h2>Prerequisites</h2>
<h2>Supported formats</h2>
<h2>Displaying AdSense ads</h2>
(and their following paragraphs)
I have translated all of them in the localization server as follows:
<h2>Resumen</h2>
<h2>Requisitos previos</h2>
<h2>Formatos admitidos</h2>
<h2>Mostrar los anuncios de Adsense</h2>
(and their following paragraphs as well)
But, they are all reported by the server as being AdSense: 5.x-1.6 (1).
This is not true as this texts strings are used in a Drupal 6.14 installation with a 6.x-1.2 version of Adsense module.
I don't know if this is information enough.
Attached there are two fresh po files just out for the server. As you may see, in adsense-all-es.po there is reference to this strings of text. They were included when I exported using the "release: All" and "Format: All in one file options". But my Drupal 6.x seems not to be able to reach them.
In adsense-6.x-1.2-es.po this strings are missing alltogether.
Thank you.
Gustavo
#3
Could it be that this texts were built in adsense.help.inc using?:
$output = <<Overview
... (trimmed)...
EOF;
return $output;
}
#4
Yes, both *.help.inc files in the module lack support for translation of that text, so Drupal will not translate them and localization server will not offer them for translation. This is an issue with Adsense module. Ideally, the titles would be standalone t() strings, while the short paragraphs would be t()-ed on their own.
Moving to adsense module.