Domain Primary Links block has wrong title

Hiya,

Both my primary and secondary domain use the same theme.

For my region I have the following blocks (both on mydomain.com/admin/build/block and on sub.mydomain.com/admin/build/block);
Domain primary links
Domain secondary links

In my template I have;

<?php if($column_left): ?>
	<?php print $column_left ?>
<?php endif; ?>

In admin/build/domain/conf/1 I have the settings (see image).

Not sure what else I should set.

My domain_conf.module says

 * @param $domain_id

The only $delta I could find in the .module file is in the function domain_conf_block on line #488.

I've added some code here for debugging purposes;

function domain_conf_block($op = 'list', $delta = 0, $edit = array()) {
	watchdog('action', 'delta test');
	watchdog('action', $delta);

Which results in these logs;

actie 2009-10-14 17:20 domain-secondary-links moderator
actie 2009-10-14 17:20 delta test moderator
actie 2009-10-14 17:20 domain-primary-links moderator
actie 2009-10-14 17:20 delta test moderator

But the difference in line numbers in our modules worries me, my domain_conf.info says;

; Information added by drupal.org packaging script on 2009-08-23
version = "6.x-2.0-rc9"

Thanx again for helping mate!

PS. what a big a$$ tree you had in your house man, made me think to take down the tree in my backyard as a precaution... yet I do love it's walnuts :)

Will have to check tomorrow can't get to it from here, thanx!!

Hi,

Well I delta'd function domain_conf_block as such;

#503

    $delta = variable_get($source, $string);
	watchdog('action', 'test-delta-test');
	watchdog('action', $delta);
    // Some domains can disable primary and secondary links.
    if (empty($delta)) {
      return;
    }

This returns the following (09:46 is a page reload on primary domain / 09:47 is a page reload on secondary domain);

actie 2009-10-15 09:47 secondary-links Anoniem
actie 2009-10-15 09:47 test-delta-test Anoniem
actie 2009-10-15 09:47 primary-links Anoniem
actie 2009-10-15 09:47 test-delta-test Anoniem

actie 2009-10-15 09:46 secondary-links Anoniem
actie 2009-10-15 09:46 test-delta-test Anoniem
actie 2009-10-15 09:46 primary-links Anoniem
actie 2009-10-15 09:46 test-delta-test Anoniem

Does this info help?

Cheers

Hmm I altered the database table {domain_conf} a bit for debugging purposes (kinda hard to read a blob so I've changed it to longtext).
The serialized array that was saved into that is as followed;

array(15) {
  ["site_mail"]=>
  string(20) "mail@isp.domain"
  ["site_slogan"]=>
  string(36) "This will be the slogan"
  ["site_mission"]=>
  string(0) ""
  ["site_footer"]=>
  string(0) ""
  ["site_frontpage"]=>
  string(6) "node/3"
  ["anonymous"]=>
  string(7) "Anoniem"
  ["site_name"]=>
  string(0) ""
  ["admin_theme"]=>
  string(10) "contentual"
  ["date_default_timezone"]=>
  string(0) ""
  ["site_offline"]=>
  string(1) "0"
  ["site_offline_message"]=>
  string(149) "De site is momenteel niet beschikbaar wegens onderhoud. De site zou binnenkort weer beschikbaar moeten zijn. Bedankt voor uw geduld."
  ["language_default"]=>
  string(0) ""
  ["menu_default_node_menu"]=>
  string(13) "primary-links"
  ["menu_primary_links_source"]=>
  string(1) "0"
  ["menu_secondary_links_source"]=>
  string(1) "0"
}

Hope this helps in defining the problem...

Cheers

What I don't understand is that in domain_conf.module in function domain_conf_block there is a variable_get that does the following;

$delta = variable_get($source, $string);
//translates into $delta = variable_get('menu_primary_links_source', 'primary-links')

This looks up the variables in {variable} and not the domain specific variables stored in {domain_conf} or am I mistaken?

Cheers

Been doing some exploring and I'm not sure if what I changed is ok or if it will cause more problems but it seems to work now.
I have attached a patch...

Let me know if my changes are ok?!

Cheers

PS. Hmmz on second thought we aren't there yet, yes it will load the correct menu for the secondary domain, but it uses the title of the menu from the primary domain as title for it... I'll look into that if you have a clue as to why please let me know!

Fixed the PS too... here's the patch.

Cheers

The domain_bootstrap_modules in {table} is a serialized array containing this

array(3) {
  [0]=>
  string(12) "domain_alias"
  [1]=>
  string(11) "domain_conf"
  [2]=>
  string(13) "domain_prefix"
}

When i do this in domain_conf.module/domain_conf_block()

<?php
global $conf;
  print '<pre>';
  print_r($conf);
  print '</pre>';
?>

I get a very large array with variables under which;
[menu_default_node_menu] => primary-links
[menu_primary_links_source] => primary-links
[menu_secondary_links_source] => secondary-links

Argh!

They don't... tried changing the slogan but it doesn't change either...
Am now completely removing the modules and installing it and setting it up again to see if that does anything!

Cheers

Disabling and uninstalling modules didn't do anything.
No error messages so I'll check the settings.php, maybe my changes got overwritten?

Cheers

Hmmz, I had this;

/**
 * Add the domain module setup routine.
 */
include './sites/all/modules/domain/settings.inc';

in the settings.php of [default] but in the settings.php of [mydomain.com] it was gone (maybe wrong revision, dunno?)
Now that I put it back in there it still doesn't work...

:'(

It's because I work locally for development and then have a copy running on a shadow location for the client to look at, every x days I upload the whole lot to the shadow location. With 2 settings folders I don't have to change the settings.php in [default] all the time...

I removed the whole dir [mydomain.com] from [sites] now but it still doesn't work (settings.php in [default] is correct).
Won't it work cause I've had this dir in there all the time??

Cheers

Can't work out whre things have gone wrong... tried almost everything to no avail.
Have started with a clean install and configuring everything all over... gonna be along weekend!

Cheers and many thanx for your help!
Bartezz

Forgot to close

Hi agentrickard,

Sorry to open this one again... came accross another problem with the menu title being used as block->subject.

in domain_conf.module function domain_conf_block the menu blocks are being build like this;

    $menus = menu_get_menus();
    $string = str_replace('domain-', '', $delta);
    $source = 'menu_'. str_replace('-', '_', $string) .'_source';
    $delta = variable_get($source, $string);
    // Some domains can disable primary and secondary links.
    if (empty($delta)) {
      return;
    }
    $data['subject'] = check_plain($menus[$string]);
    $data['content'] = menu_tree($delta);
    return $data;

As you can see $data['subject'] is set with $menus[$string]

Because this was returning unexpected values (the title of the primary and secondary menu for the main domain) I echoed some values;

    echo $string."+++";
    echo $delta."+++";
    var_dump($menus);
    $data['subject'] = check_plain($menus[$string]);
    $data['content'] = menu_tree($delta);

Which results in:

primary-links+++primarymenu--3+++array(5) {
  ["menu-primarymenu--3"]=>
  string(11) "Algemeen--3"
  ["menu-secondarymenu--3"]=>
  string(17) "Huisartsenzorg--3"
  ["secondary-links"]=>
  string(13) "Hulpverleners"
  ["navigation"]=>
  string(9) "Navigatie"
  ["primary-links"]=>
  string(8) "Over ons"
}

So as you can see $menus[$string] will return $menus['primary-links'] => 'Over ons'.

I'm not sure if this is by design but I've changed it to $data['subject'] = check_plain($menus[$delta]);
and now I'm getting the correct block->subject printed.

I'm sure it's not caused by multiple settings folders as first was the case :)
I rebuild the whole website since then....

Cheers

Hi,

I don't understand, I don't (think) I want a different menu block, I would like each subdomain to have their own custom menus shown in the same spot as the primary domain,

#1 - For each subdomain I create a new alternative primary and an alternative secondary menu.
#2 - Under admin/build/domain/conf/3 I tell the module to use menus I've created for domain 3 as the primary and secondary menus.
#3 - in blocks I'm using [Domain primary links] and [Domain secondary links] blocks

[Domain primary links] and [Domain secondary links] will look at my setting made in #2 and load the corresponding menu_tree, then why show the title of a different menu and not of the corresponding menu?

Cheers

I think we should send the human-readable name to use as the block-subject, this is what one expects to happen I suppose (at least i did :) )
The override option is a perfect solution for people who want to show all menus for all domains with the same title (within the theme as this block config is theme specific).

Sorry to be so time consuming :)

Cheers

Ah, I'll rewrite the patch to bypass if the machine-readable name of the menu is 'navigation'.
Cool?

Cheers

Could you please point me in the right direction to dynamically load this?

Cheers

since the 'Navigation' menu is supposed to use the user name as the title

Was this the case without my patch then? Just wondering...

Cheers

Hi,

In regards to #32; I'm using my patch right now and the username is actually being used as the title of the navigation-menu-block?

In regards to #37; Would this be a solution $data['subject'] = t(check_plain($menus[$delta]));

Am trying to finish the website to meet the deadline.
With your feedback I'll rewrite my patch and post it a bit later, ok?

Cheers

Hi,

Ok... Will wait for your reply.

Cheers