function twitter_content_extra_fields adds the twitter fieldset to the admin > content > content types > type name > manage fields form ( admin/content/node-type/type name/fields , "content_field_overview_form").

When content module is enabled, this patch gives the site admin the ability to reposition the twitter fieldset on the node add/edit form.

Tested with 6.x-3.x and 6.x-2.x

CommentFileSizeAuthor
#12 twitter-n604530-12.patch756 bytesdamienmckenna
#7 twitter-n604530-7.patch651 bytesdamienmckenna
#4 twitter-extra-fields-604530.patch635 bytesaaronbauman
#2 604530-twitter-hook_content_extra_fields.patch954 bytesaaronbauman
twitter.module-content_extra_fields.patch785 bytesaaronbauman

Comments

sirkitree’s picture

sirkitree commented
Version: 6.x-3.x-dev » 6.x-2.x-dev

This does apply to the 3.x branch, however it does not really pertain to it because there is no field on a content type in 3.x to send a post. It can be done through actions, but there is no field in which your function can apply itself to.

+++ twitter/twitter.module	(working copy)
@@ -140,6 +140,24 @@
+  $twitter_types = variable_get('twitter_types', array());

Grepping through the module, 3.x branch, there isn't anywhere that this variable is ever set.

Moving it to 2.x as you say it applies there, but I have not tested 2.x

aaronbauman’s picture

aaronbauman
he/him
commented
Version: 6.x-2.x-dev » 6.x-3.x-dev
StatusFileSize
new 604530-twitter-hook_content_extra_fields.patch954 bytes

The node-specific functionality moved to twitter_post.module and the variable name changed from "twitter_types" to "twitter_post_types"

The OP is still applicable to 2.x.

Please find 3.x patch attached.

dpearcefl’s picture

dpearcefl commented

BTW: The variable name is still wrong in 6.x-3.0-beta9

aaronbauman’s picture

aaronbauman
he/him
commented
StatusFileSize
new twitter-extra-fields-604530.patch635 bytes

over 2 years later... here's an updated patch.

davidneedham’s picture

davidneedham
he/him
commented
Status: Needs review » Needs work

Could we get a re-rolled patch with all of these changes and updated for the latest 6.x-5.x-dev?

dddave’s picture

dddave commented
Version: 6.x-3.x-dev » 6.x-5.x-dev
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes
Status: Needs work » Needs review
Parent issue: » #2402311: Plan for Twitter v6.x-5.2 release
StatusFileSize
new twitter-n604530-7.patch651 bytes

Rerolled.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed. Thank you.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 6.x-5.x-dev » 7.x-5.x-dev
Status: Fixed » Patch (to be ported)

The 7.x-5.x branch could use this.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: aaronbauman » Unassigned
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new twitter-n604530-12.patch756 bytes

This works for the 7.x-5.x branch.

  • DamienMcKenna committed cd1364b on 7.x-5.x 
    Issue #604530 by DamienMcKenna: Implement hook_field_extra_fields() so...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed. This isn't needed for the 7.x-6.x branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Status: Closed (fixed) » Needs work

The last submitted patch, 12: twitter-n604530-12.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Closed (fixed)

This was already committed.