The module should use Drupal behaviors, so that Cufon is loaded on AJAX calls. I'm working on a similar issue on another module (that uses selectors), and will create a patch for this here later this week.

Basically, we can't just call the $(selectors + ':not(.cufonProcessed)') as usual, since they're all comma-separated. Thus, we need to add that in the hook_init call, using str_replace(',', ',:not(.cufonProcessed', $settings), and then cache the result so we don't do that on every page.

CommentFileSizeAuthor
#8 cufon-drupal.js_.604914.patch1.03 KBjaydub
#3 patch-604914.patch1.11 KBlil.destro

Comments

rwohleb’s picture

rwohleb
he/him
Primary language English
commented
Status: Active » Needs review

I created a drupal behavior that only requires changing the cufon-drupal.js file. It's such a simple change so I'm not going to bother with rolling a patch right now. If I have time, I'll roll one.

It leaves the non-behavior code intact due to how Cufon works. Else, there would be issues with browsers like IE. The behavior is designed to skip the first global run, and also respect the context that is passed.

// $Id: cufon-drupal.js,v 1.1 2009/07/13 21:41:46 eads Exp $

// Initialize Cufon based on Drupal settings
for (o in Drupal.settings.cufonSelectors) { 
  s = Drupal.settings.cufonSelectors[o];
  Cufon.replace(s.selector, s.options)
}

// Work around Internet Explorer rendering delay
Cufon.now();

// Set a drupal behavior so that content added later can be replaced
Drupal.behaviors.cufon = function (context) {
  // Check to see if the first_run flag has been initialized
  if ( typeof Drupal.behaviors.cufon.first_run == 'undefined' ) {
      Drupal.behaviors.cufon.first_run = true;
  }
  
  // If not the first run, replace the new content.
  if (!Drupal.behaviors.cufon.first_run) {
    for (o in Drupal.settings.cufonSelectors) {
      s = Drupal.settings.cufonSelectors[o];
      Cufon.replace($(s.selector, context), s.options)
    }
  }
  
  Drupal.behaviors.cufon.first_run = false;
}
planctus’s picture

planctus commented

That's very cool :-)
It seems to work perfectly, thanks
Da.

lil.destro’s picture

lil.destro commented
StatusFileSize
new patch-604914.patch1.11 KB

Rolled this into a patch for review.

detot’s picture

detot commented
Status: Needs review » Reviewed & tested by the community

Works here to, thanks!

detot’s picture

detot commented
Status: Reviewed & tested by the community » Needs work

I'll take that back. It works if you use "h1" but not ".node h1" for example.

mediamash’s picture

mediamash commented

nice solution, should include in the module

matshep1’s picture

matshep1 commented

Thank you...this was driving me nuts! Your patch works for me :)

jaydub’s picture

jaydub commented
Status: Needs work » Needs review
StatusFileSize
new cufon-drupal.js_.604914.patch1.03 KB

Regarding the patch in #3 is it necessary to have the redundant logic? I rolled a patch before I found this issue and was wondering why a simpler approach wouldn't work. I guess there's IE to worry about?

game’s picture

game commented

Has anyone else managed to get this working recently? Im currently using the latest version of drupal and all modules. This patch didnt seem to do anything as the content was displayed the same as before I applied the patch :-/

troky’s picture

troky commented
Status: Needs review » Fixed

Committed to 6.x-1.x-dev.

Re-open issue if problem persists.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.