Cannot hide or disable tabs on search pages with Tab Tamer

same here

Got the same problem and I had a look at the code. There is a bug in the _tabtamer_convert_to_single_array function in the case there is no DEFAULT tab (local task) for a menu. In this case, the $key index is empty instead of having the last_default_path value.

Concerning the 'search' case, there is no default tab because 'search/node' is not default as it's defined with the hook_search hook like any other search type.

So here's a patch which seems to correct the bug but I'm not 100% sure it doesn't have any bad side effects so please test it on your system and review it here.

I did the following functional test of this patch:

Before applying:
- at /admin/settings/tabtamer "search" has no fieldset title
- changed 'enabled' to hidden for 'search/%user'
- click save
- form comes back with setting at 'enabled' - setting not changed

applied patch

- still no search fieldset name
- change search user to hidden
- save settings
- Now search fieldset has title "Search" with setting still set to enabled
- set to hidden again
- search/user now set to hidden and the tab is hidden as expected.
I believe the menu cache was cleared after the initial form submission after applying the patch. This seems RTBC.
Attached is a rerolled minor tweak that changes the $val['type'] == '' check to use empty in case this value is NULL and fixes the spacing of the closing parens per the Drupal coding standards.

I tested this patch with successful results in the same manner as above. Marking RTBC.

Works here! Maybe commit this patch to CVS?

thanks everyone the patch works for me :D

this patch does not work with og panels. Since og panels requires a Home tab, hiding it on the og panel removes the edit tab on all pages.

Jim

This patch also worked for me thanks.

@@ -182,7 +182,7 @@ function _tabtamer_convert_to_single_arr
 
   // If there is a MENU_DEFAULT_LOCAL_TASK at this level then set $last_default_path.
   foreach ($tabs_source as $key => $val) {
-    if (is_array($val) && $val['type'] == MENU_DEFAULT_LOCAL_TASK) {
+    if (is_array($val) && ($val['type'] == MENU_DEFAULT_LOCAL_TASK || empty($val['type']))) {
       $last_default_path = $current_path;
       break;
     }

Thanks for tracking this down!

I just noticed that this patch hasn't made it into the current release of Tab Tamer. The patch works extremely well but I wonder if perhaps this issue should remain an open issue until it is resolved in the release version?

This worked beautifully! Thank you!

Great! Thanks, hopefully commited in the next version.

Greets,
Gunther

I'm very, very sorry for the huge delay here... don't know how I overlooked this. It's been sitting in CVS for a long time now. I'm pushing a new version (1.1) which includes this patch as well as a few other fixes and enhancements. Thanks again for the work!