To prevent confusions (see for example the threads Understanding the hook system, and HOOK SYSTEM - does anyone understand it?), I believe a short explanation like the following -or similar- should be added to the introductory text on http://api.drupal.org/api/group/hooks :
"The hook codes included here are not part of the Drupal core, they are just models that you can modify. Only the hook functions implemented within modules are executed when running Drupal."
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | hooks_documentation_update_002.patch | 759 bytes | cwgordon7 |
| #4 | hooks_documentation_update.patch | 949 bytes | puddlenipper |
Comments
Comment #1
jhodgdonThis should be in a different issue queue.
Comment #2
jhodgdonThis would probably be a good project for a novice
Comment #3
puddlenipper commentedMine!
Comment #4
puddlenipper commentedAdded the text.
Comment #5
jhodgdonUmmm...
"The hook codes included below are not part of the Drupal core, they are just models that you can modify. "
I don't think this is clear... Besides which, "codes" should be "code" if we keep this sentence as-is, and "below" is not really accurate because the code is only below if you are looking at the source code in the file, not if you are looking at the text as displayed on drupal.org.
So do you think you can rewrite this in some way to make it clearer? I realize the person who submitted the issue suggested this text, but I don't think the text is really all that great...
Comment #6
cwgordon7 commentedHere's a rerolled patch incorporating the comments in #5.
Comment #7
chx commented17 year olds fixing patches by 14 year olds. /me feels ancient.
Comment #8
webchickThat's a nice clarification. Committed to HEAD!