Custom Thumbnail Files Disappear After a Few Hours

Ok, I have an update on this. Not surprisingly, when I look in the {files} table after uploading new thumbnail images, their status = 0. So when system.cron comes through to do garbage collection, the thumbnails have status FILE_STATUS_TEMPORARY, and get deleted.

After a quick grep for FILE_STATUS_, I can see that in emthumb_fetch_remote_thumbnail(), $file->status is explicitly set to FILE_STATUS_PERMANENT, but that is the only instance of the string "FILE_STATUS_" in the module, so my guess is that this is not getting done when updating a thumbnail (only when fetching a remote thumbnail set by the provider).

I think I have figured this problem out. In the switch statement inside of emthumb_emfield_field_extra(), the 'update' and 'insert' cases appear twice. Upon testing, it looks like this led to _emthumb_file_update() never getting called (because it was inside the second 'update' case).

I'll post a patch here soon.

The attached patch does two things:
1) It comments out the empty 'update' and 'insert' cases in emthumb_emfield_field_extra(). Prior to doing this, _emthumb_file_update() was never getting called - after the first 'update' case (and subsequent break), the second 'update' case would never match. This fixes my problem with thumbnails disappearing.

2) I updated the call to file_set_status() on line 458 to use the constant FILE_STATUS_PERMANENT instead of 1. Obviously this doesn't have any impact on the bug in question, but it is better form (and it makes it easier to search for "FILE_STATUS_" when debugging). ^_^