Now that both #538660: Move update manager upgrade process into new authorize.php file (and make it actually work) and #604618: Create a common interface for Archive operations so we can handle .zip, .tar.gz. are in, we need to port update.manager.inc to use the Archiver class, not directly the Archive_Tar class.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 605918-7.update_archiver.patch | 5.51 KB | dww |
| #4 | update_archiver-605918-4.patch | 5.27 KB | JacobSingh |
| #1 | 605918-1.update_archiver.patch | 5.73 KB | dww |
| #1 | 605918-1.update_archiver.before.png | 48.22 KB | dww |
| #1 | 605918-1.update_archiver.after_.png | 49.98 KB | dww |
Comments
Comment #1
dwwThis has the nice side effect of fixing a UX WTF with the "Configure block" link embedded with no visual distinction inside the system help block at the top of the page (see the upper right hand corner of 605918-1.update_archiver.before.png).
Comment #2
JacobSingh commentedComment #3
JacobSingh commentedWait, I take it back... this is fubar.
Will post something in a minute.
Comment #4
JacobSingh commentedOkay, this should do the trick.
There is one tiny kludge in there, because we're waiting on: http://drupal.org/node/604618#comment-2179010.
But if it goes in like this, no big deal either.
It's documented in the code, basically, drupal_realpath() needs to be called to ensure a local file path. If we apply the referenced patch, it does it there, this patch does it before calling the other one.
Comment #5
JacobSingh commentedComment #6
dww#604618-21: Create a common interface for Archive operations so we can handle .zip, .tar.gz. was committed to HEAD, so this needs a re-roll to remove the (now duplicate) drupal_realpath() call.
Oh, and thanks for the archiver_get_archiver() call in the updated patch... somehow I didn't notice that when #604618: Create a common interface for Archive operations so we can handle .zip, .tar.gz. was committed. ;)
Anyway, I'll re-roll this now, stay tuned.
Comment #7
dwwComment #8
JacobSingh commentedLooks good!
Comment #9
dries commentedCommitted to CVS HEAD. Thanks!
Comment #10
dwwFor those following along closely at home, http://drupal.org/cvs?commit=279220 only contains the hunk for update.module from here. The bulk of the changes for this issue are in update.manager.inc, and those were committed along with #606180: Add better validation and errors when installing new code via update manager via http://drupal.org/cvs?commit=279222. So, CVS annotate is going to be confusing and weird, but at least all the code is in core so nothing's actually broken.