Disabled sites should be class hosting-warning, enabled but problematic sites should be hosting-error

Updated screenshot. Now a site can be 'red' in two different circumstances:

1) Site is enabled but experiences an error when running a task (site 23, verify failed)
2) Site is not enabled, but has also never been verified (in other words: we have just tried to install this site, and the install failed. So technicaly the site is disabled, but it was never enabled, so it's an immediate problem) - (the tattler sites, since they aren't installable at the moment, see #605356: Tattler profile wont install from installed Tattler distribution

I'm happy to be shot down on this :)

And a patch

reverting it back to hosting-error for disabled sites until this is re-thought

However I didn't realise that a site that is *Enabled*, but has a task fail (i.e a verify, or a Disable task), changes to use the hosting-warning class too. This made it indistinguishable from disabled sites.

I don't know what's happened a year since this, but

1) sites that are enabled but fail on install are left as 'queued' but with a red error log - that's good
2) sites that are enabled but fail on a task like verify are left as 'enabled' but with a red error log - that's good
3) sites that are disabled are hosting-error, so this could become hosting-warning and improve the usability this ticket was intended for - that's good

there's a bunch of 'hosting_site_verified' in hosting_site.module related to the status map that I can't actually find anywhere else in the code:

from function hosting_site_preprocess_views_view_table

      if (isset($result->hosting_site_status) && isset($result->hosting_site_verified)) {
        $variables['row_classes'][$num][] = _hosting_site_list_class($result->hosting_site_status, $result->hosting_site_verified);

Where is this attribute ever set on $result?

Anyway, at this point I don't see why we can't:

set HOSTING_SITE_DISABLED to 'hosting-warning' in _hosting_site_list_class()

Get rid of the following bit:

   if (($status == HOSTING_SITE_ENABLED) && (!$verified)) {
     return 'hosting-warning';
   }

as I can't see where this would ever actually occur anymore (perhaps since we switched to creating revisions for the same task instead of a new task each time, and resetting the verified state? dunno)