Field patch creating error for image field on node/add/*

arianek - October 16, 2009 - 04:52
Project:Drupal
Version:7.x-dev
Component:field system
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed
Issue tags:Needs tests
Description

Fresh install of D7 HEAD, was testing image field and upon adding an image field (saved with all default settings) to the Article content type, on the /node/add/article page I now get the error:

    *  Warning: Missing argument 3 for field_info_instance(), called in /Users/arianek/Sites/drupal7/modules/image/image.field.inc on line 350 and defined in field_info_instance() (line 625 of /Users/arianek/Sites/drupal7/modules/field/field.info.inc).
    * Notice: Undefined variable: bundle_name in field_info_instance() (line 627 of /Users/arianek/Sites/drupal7/modules/field/field.info.inc).

quicksketch suspects this patch http://drupal.org/node/470242 as being responsible.

#1

arianek - October 16, 2009 - 04:56

ps. additionally, when trying to attach the image, error:

    *  Warning: Missing argument 3 for field_info_instance(), called in /Users/arianek/Sites/drupal7/modules/image/image.field.inc on line 350 and defined in field_info_instance() (line 625 of /Users/arianek/Sites/drupal7/modules/field/field.info.inc).
    * Notice: Undefined variable: bundle_name in field_info_instance() (line 627 of /Users/arianek/Sites/drupal7/modules/field/field.info.inc).
    * Warning: Missing argument 3 for field_info_instance(), called in /Users/arianek/Sites/drupal7/modules/image/image.field.inc on line 350 and defined in field_info_instance() (line 625 of /Users/arianek/Sites/drupal7/modules/field/field.info.inc).
    * Notice: Undefined variable: bundle_name in field_info_instance() (line 627 of /Users/arianek/Sites/drupal7/modules/field/field.info.inc).

but once the node is saved, the image has actually uploaded regardless of the error.

#2

quicksketch - October 16, 2009 - 04:57
Status:needs work» needs review

I think this should fix it. #470242: Namespacing for bundle names probably was committed just shortly after image field, so it wasn't accounted for in the change.

AttachmentSizeStatusTest resultOperations
image_field_object_type.patch753 bytesIdlePassed: 13667 passes, 0 fails, 0 exceptionsView details

#3

arianek - October 16, 2009 - 05:12

that patch seemed to have took care of the error, need to test more but came upon an ajax error http://drupal.org/node/606134 that kept me from going any further.

#4

bjaspan - October 16, 2009 - 21:17
Status:needs review» reviewed & tested by the community

#5

Dries - October 17, 2009 - 02:15
Status:reviewed & tested by the community» needs review

Committed to CVS HEAD.

Should have tests though so marking 'needs work'.

#6

Dries - October 17, 2009 - 02:16
Status:needs review» needs work

#7

yched - October 24, 2009 - 14:47
Status:needs work» fixed

Field UI tests are being tackled in #600544: Tests for Field UI

#8

System Message - November 7, 2009 - 14:50
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.