Hook for queue deletion

jmather - October 16, 2009 - 06:14
Project:Nodequeue
Version:6.x-2.x-dev
Component:Miscellaneous
Category:feature request
Priority:normal
Assigned:Unassigned
Status:needs work
Description

If I'm implementing a smart queue, how can I hook the delete of a queue in order to take actions based on this?

#1

ezra-g - October 19, 2009 - 04:07
Title:How to hook delete of queue in a smartqueue?» Hook for queue deletion
Version:6.x-2.4» 6.x-2.x-dev
Category:support request» feature request

Great question! The answer seems to be that you can't. It would be relatively simple to add a hook for queue deletion, probably involving nodequeue_delete(). Patches welcome :).

I'm interested to hear what kid of subqueue you're creating.

#2

jmather - October 19, 2009 - 18:05

Here is a shot at a patch. I think it is pretty simple, the only question would be if there is a better way to get the queue before the delete?

AttachmentSize
smartqueue_delete.patch 1.46 KB

#3

ezra-g - October 24, 2009 - 16:51
Status:active» needs review

Marking as needs review.

#4

ezra-g - October 24, 2009 - 20:49
Status:needs review» needs work

Thanks for the patch! This looks like a good start. We should probably place this new hook in the nodequeue_delete function, so that it will be called even when queues are deleted programatically, not just through the interface.

This looks otherwise commit worthy.

#5

jmather - October 26, 2009 - 20:55

Attached with api call moved to nodequeue_delete.

Let me know if that works.

Thanks.

AttachmentSize
smartqueue_delete.patch 1.42 KB

#6

jmather - November 14, 2009 - 01:15

Any update on getting this merged in?

Thx.

#7

ezra-g - November 14, 2009 - 01:16
Status:needs work» needs review

Sorry, this was marked as "needs work" so I didn't see it. Hope to review this weekend. Thanks for the bump!

#8

ezra-g - November 26, 2009 - 01:36
Status:needs review» needs work

Thanks for the re-roll.

This needs a bit more work before it can be committed:

A) Since we're firing this hook in nodequeue_delete instead of nodequeue_delete_submit, the hook should probably be called nodequeue_api_queue_admin_delete
B) There's no reason to pass the empty $form_state variable.

Sorry about the delay in re-reviewing this. I can turn this around quicker with another re-roll.

Thanks!

 
 

Drupal is a registered trademark of Dries Buytaert.