Posted by jmather on October 16, 2009 at 6:14am
| Project: | Nodequeue |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs work |
| Issue tags: | Simpletest |
Issue Summary
If I'm implementing a smart queue, how can I hook the delete of a queue in order to take actions based on this?
Comments
#1
Great question! The answer seems to be that you can't. It would be relatively simple to add a hook for queue deletion, probably involving nodequeue_delete(). Patches welcome :).
I'm interested to hear what kid of subqueue you're creating.
#2
Here is a shot at a patch. I think it is pretty simple, the only question would be if there is a better way to get the queue before the delete?
#3
Marking as needs review.
#4
Thanks for the patch! This looks like a good start. We should probably place this new hook in the nodequeue_delete function, so that it will be called even when queues are deleted programatically, not just through the interface.
This looks otherwise commit worthy.
#5
Attached with api call moved to nodequeue_delete.
Let me know if that works.
Thanks.
#6
Any update on getting this merged in?
Thx.
#7
Sorry, this was marked as "needs work" so I didn't see it. Hope to review this weekend. Thanks for the bump!
#8
Thanks for the re-roll.
This needs a bit more work before it can be committed:
A) Since we're firing this hook in nodequeue_delete instead of nodequeue_delete_submit, the hook should probably be called nodequeue_api_queue_admin_delete
B) There's no reason to pass the empty $form_state variable.
Sorry about the delay in re-reviewing this. I can turn this around quicker with another re-roll.
Thanks!
#9
We need this feature for one of our project. So I updated the patch from #5 updated to fit recommandation in #8.
#10
#11
Patch attached with a small code style cleanup and an extra test.
This patch is totally bunk. Grr.
#12
The last submitted patch, smerrill-606150-nodequeue-delete-hook.patch, failed testing.
#13
I fail to see what failed for the automated testing of my patch submission in #9. The log at http://qa.drupal.org/pifr/test/113444 only says "'failed to complete installation".
#14
Fails due to #996512: D6 contrib project tests: [MySQL] Drupal installation failed..
#15
#11: smerrill-606150-nodequeue-delete-hook.patch queued for re-testing.
#16
The last submitted patch, smerrill-606150-nodequeue-delete-hook.patch, failed testing.