user warning

Thanks for the bugreport, yeah, this issue is rather serious.
Can you test the attached patch?

Committed.

This problem still exists in 6.x-1.9-beta3.

subscribe.
Patch File doesn't work

It's a one line patch, it's pretty easy to change it yourself. Have a look at the patch file.

There is still a problem

With the patch (or the latest Beta), I get:
user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'DISTINCT(n.nid) FROM node n INNER JOIN node_access na ON na.nid = n.nid WHERE (' at line 1 query: SELECT n.title, DISTINCT(n.nid) FROM node n INNER JOIN node_access na ON na.nid = n.nid WHERE (na.grant_view >= 1 AND ((na.gid = 0 AND na.realm = 'all') OR (na.gid = 0 AND na.realm = 'og_public') OR (na.gid = 25 AND na.realm = 'og_subscriber'))) AND ( n.nid IN (29) )ORDER BY title DESC

I suspect this is dependent upon: #284392: db_rewrite_sql causing issues with DISTINCT

Cheers

Mark

MMm, that doesn't seem to change anything :-(

Not sure whats going on :-(

Solved:

Index: feedapi_node/feedapi_node.module
===================================================================
RCS file: /cvs/drupal-contrib/contributions/modules/feedapi/feedapi_node/Attic/feedapi_node.module,v
retrieving revision 1.1.2.18.2.47
diff -r1.1.2.18.2.47 feedapi_node.module
98c98
< $result = db_query(db_rewrite_sql("SELECT n.title, n.nid FROM {node} n WHERE n.nid IN (". db_placeholders($node->feedapi_node->feed_nids, 'int') .") ORDER BY title DESC"), $node->feedapi_node->feed_nids);
---
> $result = db_query(db_rewrite_sql("SELECT n.nid, n.title FROM {node} n WHERE n.nid IN (". db_placeholders($node->feedapi_node->feed_nids, 'int') .") ORDER BY title DESC"), $node->feedapi_node->feed_nids);

you need the nid as the first element, so that it gets the 'distinct' clause round it.

Hope this helps

Cheers

Mark.

This patch is fine, thank you Mark!

I attached this as a file. Can you confirm someone else that this helps?

I cannot understand at the moment how the order of the columns matter, but this does not matter here :) if it helps.

[ otherwise, it's a totally different problem as the initial post, the patch in #2 is really important also ]

Neither patch worked for me, but I manually replaced the offending line and the problem seems to be solved!

Thanks much...

Hey, i just wanted to thank you Mark, i patched it and works great! Couldn't do this without ppl like you!

:-)

markfoodyburton: thanks, the feedbacks seem to be good, i just committed your patch.

I updated FeedAPI to the 1.x-dev version and can confirm that this fixes the problem.