Closed (fixed)
Project:
Ubercart / Location Integration
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
16 Oct 2009 at 11:32 UTC
Updated:
6 Nov 2009 at 15:30 UTC
Hi
I am getting this php warning (I am using PHP 5.2.9):
Warning: Call-time pass-by-reference has been deprecated in /sites/all/modules/uc_location/uc_location.module on line 145
This is the warning line:
$set_primary = ( ($type == 'billing') && (_uc_location_primary_not_set(&$locations)) );
I think it should be replaced by this one according to this http://es.php.net/language.references.pass
$set_primary = ( ($type == 'billing') && (_uc_location_primary_not_set($locations)) );
Comments
Comment #1
mearnest commentedThe call time pass-by-reference has been removed. Thanks for pointing that out. There was no need for it anyway as the function definition specified a pass-by-reference for $locations.
Thanks for pointing that out. For some reason, we were not seeing the warning message.
Comment #2
mearnest commented