Patch (to be ported)
Project:
Notifications
Version:
6.x-4.x-dev
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
16 Oct 2009 at 14:35 UTC
Updated:
17 Aug 2011 at 19:36 UTC
Jump to comment: Most recent file
Comments
Comment #1
heather commentedI have found the module: Node form columns, so you have much more control.
http://drupal.org/project/nodeformcols
I made a quick demo of how this works:
http://vimeo.com/7116212
Comment #2
introfini commentedSubscribing...
Comment #3
obrienmd commentedNot sure this should really be closed, given reporter just found a workaround. This is still a valid issue.
Comment #4
David Goode commentedThis issue is somewhat complicated because notifications_team uses notification's box on the form unless it doesn't exist. Probably this setting should be added to that module instead. Please look through notification's issue queue, and if you don't see a similar thread, then move this there.
Comment #5
David Goode commentedAlso, you can probably just form_alter this yourself very easily; I'm not sure it's worth an option or anything given that there are a lot of form elements whose weights aren't controlled by CCK. That being said, if someone has a patch I'd be happy to review it.
Comment #6
obrienmd commentedPerhaps a good question is whether the team UI form should exist when the notification box doesn't? See http://drupal.org/node/760434. If we work this out, then sending this over to the queue for notifications is a no-brainer.
Comment #7
obrienmd commentedhttp://drupal.org/node/760434#comment-2939604 is now fixed, so this should probably move over to notifications. Does it make sense to have the ability to change the position of the notifications fieldset (which, in many deployments, is starting to have some really important stuff in it) in the CCK manage fields page, for content types where notifications are enabled, and when the node create and/or edit actions are enabled?
Comment #8
rootworkI think it DEFINITELY makes sense.
+1 on this feature request.
Comment #9
rootworkMarked #546312: make notifications fieldset appear on "manage fields" tab for positioning and #747360: Set weight of the options fieldset and #792002: Change notifications fieldset weight in node edit form as duplicates.
Comment #10
Michsk commentedFor me it also does make sense, i want total control over themeing and drupal gives me that, except for this fieldset...
Comment #11
David Goode commentedCan you give a module that does allow this fieldset weight setting as a precedent? I'm reluctant to just add a "weight" field on the configuration page because that seems very clumsy, but if someone submits a patch I'd be happy to look at it, it should be quite simple, and if nothing else presents itself/it seems like good practice, then it could be committed.
Comment #12
Michsk commentedfor me it does not have to be a extra module nor a new option in the UI of this module. When i can change it trough form_alter i am happy.
Comment #13
dmetzcher commentedIasac: How do you do this via form_alter? I've never done it before, but I'd love to know because it seems like something I could use for other things.
As far as adding a setting, does http://drupal.org/project/nodeformcols accomplish this for us (and for every other item that appears on a node edit form)? Looks like an interesting module. I may give it a test today, but if anyone else has any experience with it, I'd love to hear about it.
Edit: Heather posted a demo of nodeformcols -- http://vimeo.com/7116212 (watching this right now)
Edit: Thank you, Heather, for posting your demo! It looks like http://drupal.org/project/nodeformcols does the trick, and it's pretty slick, too!
Comment #14
obrienmd commentedSeems odd to have to use a secondary module just to modify the weight of a fieldset in a node form. Should this not be draggable (as many other things are) in content type setup?
Comment #15
rootworkAgreed. Nodeformcols is a nice module, but not always practicable (and has some conflicts, like admin.module).
Any number of modules expose themselves on the manage fields page of a content type. I don't see any reason why this one wouldn't, and I don't think it should require a different module to make it happen.
So @David Goode, I wouldn't suggest making it a field on the configuration page, just making it available on the manage fields page so that it can be weighted along with everything else in the form.
Comment #16
obrienmd commented+1 to #15.
Comment #17
dmetzcher commentedrootwork: Yeah, I guess you're right. Having the ability to move things around on the manage fields page, even if using the nodeformcols module, is still a nice thing, especially since it would give us the ability to control its position on the node that is displayed, not just the node-edit form, correct?
We should also ask the maintainer of the Subscriptions module to add this feature, since one goes with the other and both modules were the reason I installed nodeformcols. I've submitted a feature request (copying the the body of this request) for that module:
Change weight of the Subscriptions fieldset in CCK 'manage fields' page
Comment #18
dmetzcher commentedThis has been added to the Subscriptions module (dev version). The maintainer of that module did it today.
http://drupal.org/node/817342#comment-3047188
Comment #19
David Goode commentedSomeone should have told me the patch was so easy :-) This allows changing the weights in the CCK field page, please test, especially if form submissions works as expected for the subscriptions subform. Probably will commit once reviewed and I talk to Jose.
Comment #20
dmetzcher commentedI must have been confused... will this patch also allow the "Subscriptions" fieldset to be moved around on the Manage Fields page?
Or... and this is where I'm a little confused... is the Subscriptions fieldset managed by another module?
I thought I had installed the "Subscriptions" module (I took a guess that was the name because that was the name of the fieldset), so I asked the developer of that module to add this functionality to his module. He did, and so I went to update it and found that it's not even installed. LOL... So now I'm trying to figure out if the fieldset called "Subscriptions", on the node-edit form (and on the viewed node if this option is checked off in the UI settings: "Form on node pages. A collapsible subscriptions form will be displayed for full node pages."), is managed by this module.
If it helps, all the settings for Notifications and Subscriptions and Messaging are grouped into their own menu item if the Admin Menu module is installed.
Sorry for my silly confusion... I just want to make sure that we covered both fieldsets, and if the "Subscriptions" fieldset is not provided by this module, I'd like to find its developer and ask him/her to add this feature there, too. Thanks!
Comment #21
jose reyero commentedLooks good, committed (to 4.x branch). Thanks David.
Btw, we are *not backporting* new features to 2.x branch.
Comment #23
ñull commentedI wonder if this is really a feature when apparently all fields allow this behaviour and it has become expected behaviour. Since 2.3 is still the recommended version I kindly request to port this to the 2.x-dev branch too.
Not everybody would like to use a beta release on their production site, not to speak of all the unexpected side effects of an upgrade.