[Needs rollback] Remove trailing whitespaces and add newlines at end of files

All of HEAD covered.

Using the right CVS diff options would probably help with getting the patch to apply.

This script should ideally go into the testbot's list of things to check. It'd help with Dries' implementation of step 7 here http://buytaert.net/8-steps-for-drupal-8

Here's an updated patch and script that checks for newlines at the end of files as well.

#!/bin/bash
for ext in "info" "css" "txt" "sh" "profile" "install" "test" "module" "inc" "php" "js"
do
  find . -type f -name "*.$ext" -exec sed -i 's/[[:space:]]*$//' {} \;
  find . -type f -name "*.$ext" -exec sed -i '${/^$/!s/$/\
/;}' {} \;
done

Added the --no-prefix option so that it'll work now.

Here's a patch that should hopefully work, thanks to DamZ on IRC. Rolled against the git mirror of the cvs repository instead of a local git project created after checking out HEAD from cvs.

Good idea, #17. Didn't refresh the page before I hit submit, so I'll reroll now with two distinct patches.

Got it :D. Drastically reduces the size of the patch as well. Two separate patches posted for review, the combined patch is for committing purposes. I also updated the script a bit, so that's here as well.

Script assumes you've got a git clone of the repo in the drupal subdirectory in your current working path.

#!/bin/bash

cd drupal/
git checkout .

for ext in "info" "css" "txt" "sh" "profile" "install" "test" "module" "inc" "php" "js"
do
  find . -type f -name "*.$ext" -exec sed -i 's/[[:space:]]*$//' {} \;
done
git checkout misc/ui/
git status
git diff --no-prefix > ../line_ends_axyjo.patch

#clean up directory for new patch.
git checkout .
git status

for ext in "info" "css" "txt" "sh" "profile" "install" "test" "module" "inc" "php" "js"
do
  find . -type f -name "*.$ext" -print | xargs printf "e %s\nw\n" | ed -s;
done
git checkout misc/ui/
git status
git diff --no-prefix > ../file_ends_axyjo.patch

#clean up directory for new patch.
git checkout .
git status

for ext in "info" "css" "txt" "sh" "profile" "install" "test" "module" "inc" "php" "js"
do
  find . -type f -name "*.$ext" -exec sed -i 's/[[:space:]]*$//' {} \;
  find . -type f -name "*.$ext" -print | xargs printf "e %s\nw\n" | ed -s;
done
git checkout misc/ui/
git status
git diff --no-prefix > ../combined_ends_axyjo.patch

cd ..
#rm -rf drupal/

Forgot this.

Here it is, updated based on the latest HEAD.

Hmm. I wonder if reverting the modules/simpletest/files directory will help the file ends patch pass. Here are the patches when those files are excluded. Line ends patch remains the same, so it isn't uploaded this time around. Since the combined patch has both of them, I'll just upload the file ends patch. Updated script:

#!/bin/bash

cd drupal/
git checkout .

for ext in "info" "css" "txt" "sh" "profile" "install" "test" "module" "inc" "php" "js"
do
  find . -type f -name "*.$ext" -exec sed -i 's/[[:space:]]*$//' {} \;
done
git checkout misc/ui/
git status
git diff --no-prefix > ../line_ends_axyjo.patch

#clean up directory for new patch.
git checkout .
git status

for ext in "info" "css" "txt" "sh" "profile" "install" "test" "module" "inc" "php" "js"
do
  find . -type f -name "*.$ext" -print | xargs printf "e %s\nw\n" | ed -s;
done
git checkout misc/ui/
git checkout modules/simpletest/files/
git status
git diff --no-prefix > ../file_ends_axyjo.patch

#clean up directory for new patch.
git checkout .
git status

for ext in "info" "css" "txt" "sh" "profile" "install" "test" "module" "inc" "php" "js"
do
  find . -type f -name "*.$ext" -exec sed -i 's/[[:space:]]*$//' {} \;
  find . -type f -name "*.$ext" -print | xargs printf "e %s\nw\n" | ed -s;
done
git checkout misc/ui/
git checkout modules/simpletest/files/
git status
git diff --no-prefix > ../combined_ends_axyjo.patch

cd ..
#rm -rf drupal/

Awesome! Since that script got the green light from the testbot, here are the files again. file_ends and line_ends are just for the reviewer's sake and the actual file to patch/commit with is combined_ends.

Updated patch. Left at RTBC since both brianV and scor have looked at it.

Agreed. Added an exception to jQuery files in the script. Here's the patch without it.

#!/bin/bash

cd drupal/
git checkout .

for ext in "info" "css" "txt" "sh" "profile" "install" "test" "module" "inc" "php" "js"
do
  find . -type f -name "*.$ext" -exec sed -i 's/[[:space:]]*$//' {} \;
done
git checkout misc/ui/
git checkout misc/jquery.*
git status
git diff --no-prefix > ../line_ends_axyjo.patch

#clean up directory for new patch.
git checkout .
git status

for ext in "info" "css" "txt" "sh" "profile" "install" "test" "module" "inc" "php" "js"
do
  find . -type f -name "*.$ext" -print | xargs printf "e %s\nw\n" | ed -s;
done
git checkout misc/ui/
git checkout modules/simpletest/files/
git checkout misc/jquery.*
git status
git diff --no-prefix > ../file_ends_axyjo.patch

#clean up directory for new patch.
git checkout .
git status

for ext in "info" "css" "txt" "sh" "profile" "install" "test" "module" "inc" "php" "js"
do
  find . -type f -name "*.$ext" -exec sed -i 's/[[:space:]]*$//' {} \;
  find . -type f -name "*.$ext" -print | xargs printf "e %s\nw\n" | ed -s;
done
git checkout misc/ui/
git checkout modules/simpletest/files/
git checkout misc/jquery.*
git status
git diff --no-prefix > ../combined_ends_axyjo.patch

cd ..
#rm -rf drupal/

Rerolled patch with scor's new script.

Aren't all jQuery libs basically 1 LOC due to compression/packer? So that's upto 20 lines total in a file. 20 bytes saved by changing CRLF to LF times 41 (number of jQuery files in misc/ and misc/ui/) = 820 bytes saved overall. Is it really worth it in terms of file size?

+ scor brings up a good issue about jQuery being an external library.

Agreed with scor. This reduces our work since we don't have to patch the files every single time an external library updates (even though we freeze the version in our tree).

With coder integration now in the test bot, I really think that this should be fixed ASAP. Bumping the priority up and bumping the status down until I do a re-roll.

Here's that re-roll I promised. Setting back to RTBC since it's the same script that's used.