Closed (fixed)
Project:
CKEditor 4 - WYSIWYG HTML editor
Version:
6.x-1.0-beta1
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
16 Oct 2009 at 16:38 UTC
Updated:
21 Feb 2011 at 10:45 UTC
Jump to comment: Most recent file
Comments
Comment #1
mephir commentedPatch for Imagebrowser, Version 1.
Comment #2
jdelaune commentedThanks, I'll review this asap and see what I can do. I'll also write another plugin for IBv2 for the CKeditor project. The sooner everyone uses CKeditor the better :P
Comment #3
jdelaune commentedAwesome worked a treat. I'll commit this to the 6.x-1.0-dev branch tonight. And I'll do the plugin for IBv2 soon.
Comment #4
wwalc commentedActually, I there is one problem with ImageBrowser integration.
This patch is pretty basic and adds support for sending image Url, without sending any extra information like linking to node, alignment etc.
I think we can go ahead with this patch for now and try providing support for all other features that I mentioned later (in a separate issue, it may require changes in CKEditor core, I have to dig into this). Sounds ok?
Comment #5
jdelaune commentedSure let me know when you want me to do something.
Comment #7
alfthecat commentedHi,
I tried to patch the imagebrowser.info file with the file from #1 but I get a failure.
I use the imagebrowser version 1 RC from july 19. I would like to use the imagebrowser module with Ckeditor, so I'm curious about the status for this integration and if there is a new patch available maybe...
Thanks!
.rej contents:
***************
*** 12,34 ****
function SelectFile(url, width, height, alt, link, link_target, styles)
{
if(window.opener) {
//url, width, height, alt
- window.opener.SetUrl( url, width, height, alt );
-
- if (window.opener.GetE('txtLnkUrl')) {
- window.opener.GetE('txtLnkUrl').value = link ;
}
- if (window.opener.GetE('cmbLnkTarget')) {
- window.opener.GetE('cmbLnkTarget').value = link_target ;
- }
- if (window.opener.GetE('txtAttClasses')) {
- if(styles == '') {
- window.opener.GetE('txtAttClasses').value = 'ibimage';
}
- else {
- window.opener.GetE('txtAttClasses').value = 'ibimage ' + styles;
}
}
}
--- 12,52 ----
function SelectFile(url, width, height, alt, link, link_target, styles)
{
if(window.opener) {
+ var href=window.location.href.split('&');
+ var app=false;
+ var cfunc=false;
//url, width, height, alt
+ for(var x in href){
+
+ if(href[x].match(/app=[a-z]/i)){
+ app=href[x].split('=');
+ app=app[1];
+ }
+ if(href[x].match(/^CKEditorFuncNum=\d+$/)){
+ cfunc=href[x].split('=');
+ cfunc=cfunc[1];
+ }
}
+ if(app=='ckeditor'){
+ window.opener.CKEDITOR.tools.callFunction( cfunc, url);
+ } else {
+ window.opener.SetUrl( url, width, height, alt );
+ if (window.opener.GetE('txtLnkUrl')) {
+ window.opener.GetE('txtLnkUrl').value = link ;
+ }
+ if (window.opener.GetE('cmbLnkTarget')) {
+ window.opener.GetE('cmbLnkTarget').value = link_target ;
}
+
+ if (window.opener.GetE('txtAttClasses')) {
+ if(styles == '') {
+ window.opener.GetE('txtAttClasses').value = 'ibimage';
+ }
+ else {
+ window.opener.GetE('txtAttClasses').value = 'ibimage ' + styles;
+ }
}
}
}
Comment #9
dczepierga commentedI closed this issue because is not active over 1 year.
If u have any questions pls reopen it.
Greetings