Closed (fixed)
Project:
Drupal core
Version:
5.x-dev
Component:
comment.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
27 Apr 2006 at 12:18 UTC
Updated:
8 Jan 2007 at 23:30 UTC
Jump to comment: Most recent file
Comments
Comment #1
markus_petrux commentedI guess this message is written to note a user entered a duplicated message. Not sure how much sense there is, but maybe there is little sense when one just changes the status, the user or the date of the message?
What if this message was not written when the user has 'administer comments' permission and it is editing a comment. ie. write the message when creating, but not when editing (even if the text is being changed, let's suppose the admin knows what (s)he is doing...).
Comment #2
markus_petrux commentedThis is the code snippet, located in comment_save():
Does anyone know what "Note that we have to use the validated/filtered data to perform such check." means?
Also, note that comment duplicates are checked only against the same node and comment parent. That makes me think it is to prevent users from posting the same comment twice. If so, what we have here is pretty useless. The message is sent only to watchdog, so...
I'm wondering if it would be better to remove that check?
Comment #3
heine commentedDoesn't change much, except moves the duplicate checking to work for new comments only.
Comment #4
heine commentedstatus
Comment #5
drummCommitted to HEAD.
Comment #6
drummComment #7
(not verified) commented