873a67d9af5eca3d65aa78d0c0bb2574c0d9849d - This commit, and some of the subsequent ones, are interesting. Really seem like places to consider employing some of the classes in the SplFileInfo family.

@sdboyer: SplFileInfo can be our parent class. Maybe you can get into some details to understand you better?

Comments

sdboyer’s picture

sdboyer commented
Priority: Normal » Minor

SPL offers classes for both traversing directories and accessing file objects - DirectoryIterator, RecursiveDirectoryIterator, SplFileInfo, SplFileObject are the biggies. I personally am a much bigger fan of using these to do filesystem operations than more taped-together stuff with the procedural calls. So if we make VersioncontrolItem into a child of SplFileObject, and potentially extend (Recursive)DirectoryIterator to interact with some of the specific features that we add to our VersioncontrolItem class, then we could maybe do some nifty stuff.

However, all of this qualifies as nifty, not strictly necessary, and should not be touched until the major stuff is out of the way.

marvil07’s picture

marvil07 commented
Version: 6.x-1.0-rc2 » 6.x-2.x-dev
marvil07’s picture

marvil07 commented
Status: Active » Closed (won't fix)

We are relying mainly on what backend vcs-specific-library can do on interaction points, so IMHO we can close this as we are not really dealing with general operations that include the logic of SplFileInfo AFAIK and IIRC.

Please re-open if I am completely wrong :-p