Node creation breaks if no path is specified

In path_node_insert() we need to control not only if is set $node->path but also if this field is not empty.
Otherwise path.module create always a empty path.
The following pacth fix this problem.

@peximo's patch adds !empty check to hook_node_insert alone. In my opinion it should be added to hook_node_validate and hook_node_update as well. hook_node_validate is where the "The path is already in use." error message is generated and thus prevents from node creation.

Testing this patch. I still get an error trying to add an article or blog post.

Error: The path is already in use.

Also noticed, when i manually create the url alias, it accepts spaces in the url. Shouldn't it automatically replace the spaces with dashes instead. should this filed as a separate issue?

_{This review is powered by Dreditor.}

+++ modules/path/path.module	17 Oct 2009 12:59:00 -0000
@@ -161,7 +161,7 @@ function path_delete($criteria) {
+  if (user_access('create url aliases') || user_access('administer url aliases') && !empty($node->path)) {

Don't use empty because in the (rare) case someone wants to add "0" as alias that would fail.
Use $node->path != '' instead.

oops.. There was a mistake in my previous patch

if (user_access('create url aliases') || user_access('administer url aliases') && !empty($node->path)) {

should be

if ((user_access('create url aliases') || user_access('administer url aliases')) && !empty($node->path)) {

Attached is a patch which corrects this mistake and replaces empty() with != check.

Maybe, i'm doing something wrong but patch failed:

patch -p0 -u < url_alias-606888-4.patch

patching file modules/path/path.module
Hunk #1 FAILED at 161.
Hunk #2 FAILED at 201.
Hunk #3 FAILED at 217.
3 out of 3 hunks FAILED -- saving rejects to file modules/path/path.module.rej

Rerolled

Works.

Yep, works for me too.

One issue though, when i tried to remove the url alias it wouldn't allow me. i'm able to save but old url alias still remains there. Should it not just default back to the internal url alias (ie, node/2)? I guess this might be a separate issue?

patch works for me.

2 notes:

+++ modules/path/path.module	17 Oct 2009 16:38:32 -0000
@@ -161,7 +161,7 @@ function path_delete($criteria) {
+  if ((user_access('create url aliases') || user_access('administer url aliases')) && ($node->path != '')) {
     if (isset($node->path)) {

Code is excuted only when both if statements are TRUE, they should be combined into 1 statement (and this will make the validate function match insert and update).

This needs to have a test attached. I think this issue is critical enough to go in right away even w/o a test, but there should definitely be some follow up.

The fix patch is on this page: http://drupal.org/node/332333

Looks like it is fixed. I don't see any error message or an empty alias in {url_alias} table.

I have just tested a fresh install - and I don't get a break on node creation.

Where/when did this get fixed?

I'd like to make the error highlight in red, as well as some UI text changes.

Anyone know where this issue was fixed?

Shall we close this?