Refactor install.sh, INSTALL.txt to take into account other platforms (including CentOS)

Yeah I agree with this.

What if we had 'SETUP_DEBIAN.txt' and 'SETUP_REDHAT.txt' files that dealt with system-level preparation (installing programs), and reduced the INSTALL.txt to just creating the directory structure and mysql commands.

And that opens the door to further 'official' instructions for SETUP_BSD.txt etc. The problem with the g.d.o documentation is that (like all wikis) it gets out of date very quickly. Putting some of this stuff in the package itself is an incentive to keep the instructions up to date and users happy.

The end of each SETUP.txt would have 'please refer to the INSTALL.txt to begin the installation procedure.'

This seems to be working ok, just a few things:

1) As you know, '/var/aegir/drush/drush' in the install.sh causes problem in drush 2.1's current state. The classic old chestnut "?php no such file or directory". I worked around this by modifying the path to DRUSH (both in the main config as well as where you change the variable again if drush needs to be downloaded via wget) to include a 'php' prefix and use the drush.php as opposed to the shell script.

On the other hand as you mentioned, you could apply your patch to drush to fix the issue :) but you are then assuming that the patch will apply cleanly, what if the user already had downloaded drush, you will have to assume it works ok already maybe.. ? Personally my attitude is 'to hell with the shell script' and I use php /path/to/drush/drush.php in all cases. It's also consistent with our crontab entry etc as well as a result.

2) The INSTALL.txt is followed up til one runs install.sh. The install.sh then instructs the user to visit the site in the browser to complete the install. However the next command in INSTALL.txt is to restart apache to apply the changes from earlier. The user must remember to come back to the INSTALL.txt and effectively ignore the instructions outputted at the end of the install.sh. I initially thought the easiest solution would be to restart apache at the end of the install.sh, and then I remembered that the script is run as the aegir user.

So:

a) add aegir to sudoers in the install script (also see 3) ) and restart apache in the script, or
b) modify the instructions at the end of the install script to say 'Now restart apache, and then visit http://$AEGIR_SITE/install.php', so that the user doesn't have to return to the INSTALL.txt

3) Speaking of sudoers, we should include sudo as a dependency in the install.sh script. I was pretty sure we used to prior to the refactor, but on a fresh install of Debian and after running the install script, I didn't have sudo still. Remember that an install of Debian with nothing but the Standard System in tasksel doesn't include sudo.

I would supply a patch but i'm not sure which way you want to go with 1) .

I remembered that the install.sh doesn't do any debian-centric stuff like apt-get, so this is not the place to add sudo as a dependency. I added it in INSTALL.txt alongside cvs and unzip.

Also committed addition of sudo and unzip as dependencies in the HINTS_CentOS.txt.

Nice. There was also another issue I noticed, the < Directory > tag referenced the template path to the platform (i.e it wasn't being replaced with sed or anything during the script like the rest)

I was working on a fix and then I saw you fixed it already :)

I'm happy with the rest of the fixes, cheers.

note to self so I don't forget to fix this

aegir1:~# /etc/init.d/apache2 restart
Restarting web server: apache2Syntax error on line 15 of /var/aegir/config/vhost.d/aegir1.mig5-forge.net:
<Directory> directive missing closing '>'
 failed!