Hi

I've done an Importer Module for Location which is able to read data from "Profile-Fields" or CSV and imports and instances it.
For geocoding I've used the Webservice described at: http://code.google.com/intl/en/apis/maps/documentation/geocoding/index.html

Now some things occurred to me:

- The postal_code should be Varchar(**) because actually there're postal_codes containing letters!
- Lat/Lon should've 2 more diggits because the Google-API delivers them!
- The Country-Codes aren't ISO 3166 conform. Google sends GB for London for example and Location expects UK!
Please have a look on: http://en.wikipedia.org/wiki/ISO_3166

Please response if this changes should go to the Location-Core.
For sure I'll support the work !!

kind regards

sven rissmann

Comments

svenrissmann’s picture

svenrissmann commented

Hi

I've to say sorry.
I should look before posting ;)

I saw that in the .install you're already thinking about putting 1 more diggit to lat/lon whats about 2 more?
And the difference between some country-codes is resulting from an Update of the ISO-3166 where UK gets GB etc.

Please just let me know if you have this alreay on you To-Do List.
For sure I'ld help by contributing this parts of code!

regards

ankur’s picture

ankur commented
Status: Needs review » Closed (works as designed)

I believe the postal_code column is already a varchar.

There're at least 2 other issues that already talk about using the proper ISO code for the United Kingdom.

The only one here that's up in the air, then, would be preserving the extra 2 digits sent over by google for geocoding. If there's still a request for this last one, please re-open and change the version to 7.x-4.x, as that is where new features are going.