"Fatal error: Cannot use string offset as an array" when deleting multiple nodes on admin/content.

CommentFileSizeAuthor
#31 607100_node_delete_test_nids.patch3.74 KBavpaderno
#28 607100_node_delete_test_lst.patch3.8 KBavpaderno
#24 607100_node_delete_test_crfng.patch3.8 KBavpaderno
#20 607100_node_delete_test_new_version.patch3.8 KBavpaderno
#18 607100_node_delete_test_corrected_comments.patch3.86 KBavpaderno
#15 607100_node_delete_test_rerolled.patch3.8 KBavpaderno
#13 607100_node_delete_test.patch3.7 KBavpaderno
#9 607100-node-multiple-delete-9.patch3.6 KBsivaji_ganesh_jojodae
#6 node_multiple_delete-607100-6.patch5.37 KBpeximo
#5 node_multiple_delete-607100-5.patch5.27 KBpeximo
#1 node_multiple_delete-607100-2.patch820 bytespeximo

Comments

peximo’s picture

peximo commented
Status: Active » Needs review
StatusFileSize
new node_multiple_delete-607100-2.patch820 bytes

Wrong args are passed to node_multiple_delete_confirm().

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented

The above patch works fine for me.

jim0203’s picture

jim0203 commented
Status: Needs review » Reviewed & tested by the community

Works fine for me too. $form wasn't being passed to node_multiple_delete_confirm(); this patch fixes that. RTBC.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests

Committed to CVS HEAD, but we need to follow-up with a test.

peximo’s picture

peximo commented
Status: Needs work » Needs review
StatusFileSize
new node_multiple_delete-607100-5.patch5.27 KB

Added tests for single and multiple deletion for both pages and articles.

peximo’s picture

peximo commented
StatusFileSize
new node_multiple_delete-607100-6.patch5.37 KB

Sorry the previous patch has an uncorrect comment due to cut and paste.

cosmicdreams’s picture

cosmicdreams commented
Issue tags: -Needs tests

#6: node_multiple_delete-607100-6.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Needs tests

The last submitted patch, node_multiple_delete-607100-6.patch, failed testing.

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented
Status: Needs work » Needs review
StatusFileSize
new 607100-node-multiple-delete-9.patch3.6 KB

Attached patch adds test for node delete.

moshe weitzman’s picture

moshe weitzman commented
Title: Node multiple delete fatal error » Node multiple delete tests (was fatal error)
codesmith’s picture

codesmith
Location San Francisco
commented
Status: Needs review » Reviewed & tested by the community

Applied patch and tested -> no errors. Ran coder module -> no problems found. Reviewed logic and seems fine. Noticed that the "single node deletion" tests deletion of different node types (article and page) whereas "multiple node deletion" tests deletion of multiple nodes - but they're all of a single node type (article). I think this is minor but just thought I'd mention.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Reviewed & tested by the community » Needs work 
+++ modules/node/node.test	1 Apr 2010 15:09:17 -0000
@@ -1599,3 +1599,87 @@ class NodeQueryAlter extends DrupalWebTe
+    // Check that the five nodes have been created.
+    $count = db_select('node')
+      ->countQuery()
+      ->execute()
+      ->fetchField();
+    $this->assertEqual($count, 5, t('Found five nodes in database.'));

This does not seem right, if there are other nodes already there the test will fail. Or can we assume that the node table is always empty when simpletest runs?

Powered by Dreditor.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new 607100_node_delete_test.patch3.7 KB

I changed how the test checks if the nodes are created, and if the nodes has been deleted.

Status: Needs review » Needs work

The last submitted patch, 607100_node_delete_test.patch, failed testing.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new 607100_node_delete_test_rerolled.patch3.8 KB

I re-rolled the patch, which didn't apply anymore.

IcanDivideBy0’s picture

IcanDivideBy0 commented

#6: node_multiple_delete-607100-6.patch queued for re-testing.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Needs work 
+++ modules/node/node.test	31 May 2010 16:07:28 -0000
@@ -1668,6 +1668,87 @@ class NodeQueryAlter extends DrupalWebTe
+    // create node

punctuation missing, comment should start with capital letter

+++ modules/node/node.test	31 May 2010 16:07:28 -0000
@@ -1668,6 +1668,87 @@ class NodeQueryAlter extends DrupalWebTe
+   *  Test multiple node delete from admin/content page

punctuation is missing.

+++ modules/node/node.test	31 May 2010 16:07:28 -0000
@@ -1668,6 +1668,87 @@ class NodeQueryAlter extends DrupalWebTe
+    // Create five node.

should be nodes (plural)

+++ modules/node/node.test	31 May 2010 16:07:28 -0000
@@ -1668,6 +1668,87 @@ class NodeQueryAlter extends DrupalWebTe
+    // Delete all created nodes

punctuation is missing

79 critical left. Go review some!

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new 607100_node_delete_test_corrected_comments.patch3.86 KB

I changed the comments, and the output of one test.

Status: Needs review » Needs work

The last submitted patch, 607100_node_delete_test_corrected_comments.patch, failed testing.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new 607100_node_delete_test_new_version.patch3.8 KB

I re-rolled the patch, which was not applying anymore.

Status: Needs review » Needs work
Issue tags: -Needs tests

The last submitted patch, 607100_node_delete_test_new_version.patch, failed testing.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review

#20: 607100_node_delete_test_new_version.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Needs tests

The last submitted patch, 607100_node_delete_test_new_version.patch, failed testing.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new 607100_node_delete_test_crfng.patch3.8 KB

Never create patches if you didn't sleep enough.

Status: Needs review » Needs work
Issue tags: -Needs tests

The last submitted patch, 607100_node_delete_test_crfng.patch, failed testing.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review

#24: 607100_node_delete_test_crfng.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Needs tests

The last submitted patch, 607100_node_delete_test_crfng.patch, failed testing.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new 607100_node_delete_test_lst.patch3.8 KB

I re-rolled the patch once again.

damien tournoud’s picture

damien tournoud commented

Could we please use the nids instead of the titles to check for deleted nodes? Titles are not unique, and checking the nids will remove a few lines from the test.

Status: Needs review » Needs work

The last submitted patch, 607100_node_delete_test_lst.patch, failed testing.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new 607100_node_delete_test_nids.patch3.74 KB

I changed the patch as suggested.

thedavidmeister’s picture

thedavidmeister commented
Title: Node multiple delete tests (was fatal error) » Tests for Node multiple delete tests (was fatal error)
Version: 7.x-dev » 8.x-dev
Component: node.module » ajax system
Category: Bug report » Task
Issue summary: View changes
Status: Needs review » Needs work

Pulling these tests through to D8 as they're likely still useful there.

+ * Test multiple node delete from admin/content page

should end with a full stop.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

  • Dries committed eb84b86 on 8.3.x 
    - Patch #607100 by peximo: fixed node multiple delete fatal error.

  • Dries committed eb84b86 on 8.3.x 
    - Patch #607100 by peximo: fixed node multiple delete fatal error.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

  • Dries committed eb84b86 on 8.4.x 
    - Patch #607100 by peximo: fixed node multiple delete fatal error.

  • Dries committed eb84b86 on 8.4.x 
    - Patch #607100 by peximo: fixed node multiple delete fatal error.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

  • Dries committed eb84b86 on 9.1.x 
    - Patch #607100 by peximo: fixed node multiple delete fatal error.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.