Download & Extend
Pageroute » Issues

Add ability to show/hide the menu item, and change the title of the menu item for a pageroute

Posted by singularo on October 17, 2009 at 11:03pm
Project:Pageroute
Version:6.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:needs work

Issue Summary

I didn't want the menu item to show, so added the option of making it a MENU_CALLBACK, so its still usable, but has to be directed to manually.

The other alternative is to make the title friendly, rather than just using the url string, which I've done in this patch as well.

Patch attached.

AttachmentSize
pageroute.patch3.43 KB
Login or register to post comments

Comments

#1

Posted by sepgil on October 24, 2009 at 11:32am

There are some issues in your patch:

  • please use relative path for your patches. I don't have a directory "simon" in my home folder ;-)...
  • I get a lot of warnings:
    # notice: Undefined index: hide_menu in /home/sebastian/work/projects/Pageroute/pageroute.module on line 62.
    # notice: Undefined property: stdClass::$menu_title in /home/sebastian/work/projects/Pageroute/pageroute.module on line 74
  • watch out for code style issues

#2

Posted by sepgil on October 25, 2009 at 11:07am
Status:needs review» needs work