Allow passing variables that need to be saved to drupalCreateContentType()

This seems like a reasonable addition to the testing framework, but you need slightly better documentation -- the variable that is being saved is key_typename, and this is not documented in your proposed documentation header for the $vars parameter.

How about instead of using "bar" for the variable value, you use "value"? I think it is clearer. Also, we normally just continue the doc on the same line, rather than having a return in the middle of something like this:

+   * @param $vars
+   *   An array with variables that need to be saved, before the content type is
+   *   created. Example: 'var' => 'bar'.
+   *   The variables are saved in the form of [variable]_[content type name].

One other thing. I think you will need to add a test to your patch for this behavior -- test whether this new addition works within the testing framework.

One minor thing in a doc header; other than that, I like the patch in #6:

+   * @param $vars
+   *   An array with variables that need to be saved, before the content type is
+   *   created (e.g. array('var' => 'value')). The variables are saved in the
+   *   form of [variable]_[content type name].

How about making 'var' agree with [variable] here? So change this to:

+   * @param $vars
+   *   An array with variables that need to be saved, before the content type is
+   *   created (e.g. array('variable' => 'value')). The variables are saved in the
+   *   form of [variable]_[content type name].

Whoops, the test bot came through while I was posting that... looks like maybe the test bot is having trouble, so I have requested a retest.

OK, I like your patch now. Apparently the Drupal 7 testing engine is not so happy with it, either that or the Drupal 7 testing engine is having trouble itself...

OK, I am happy with the patch -- I think it is clearly written and the documentation headers are good.

I will leave it to someone else to figure out whether this feature should be added to the SimpleTest module.

#13: 607828-content-type-save-vars-13.patch queued for re-testing.

Patch did not apply.

+   * @param $vars
+   *   An array with variables that need to be saved, before the content type is
+   *   created (e.g. array('var' => 'value')). The variables are saved in the
+   *   form of [variable]_[content type name].
    * @return
    *   Created content type.

Add a space between @param and @return.

+/**
+ * Test simpletest functions.
+ */
+class SimpleTestAssertUnitTest extends DrupalWebTestCase {
+  public static function getInfo() {
+    return array(
+      'name' => 'SimpleTest unit tests',
+      'description' => 'Test the simpletest unit testing functions.',
+      'group' => 'SimpleTest',
+    );
+  }
+
+  /**
+   * Test creating a new content type and saving the content type variables.
+   */
+  function testDrupalCreateContentType() {
+    $content_type = $this->drupalCreateContentType(array(), array('var' => 'value'));
+    $this->assertTrue(variable_get('var_' . $content_type->type, '') == 'value', t('Variable was saved when creating the new content type.'));
+  }
+}

This test looks like it could be better named and documented than simple "SimpleTestAssertUnitTest". Have a look at other tests in that file for examples.

I'm trialling something a bit different at #2094585: [policy, no patch] Core review bonus, I'd like to use this review for a bonus at #1987396: Refactor & Clean-up comment.module theme functions.

oh, additionally, new features should be filed against latest version of core and back-ported after commit.

This got fixed in the meantime, mostly by moving to config entity types..