Checking/unchecking the "test group" doesn't select/deselect all it's "tests"

Select/deselect the "top" checkbox works.

CommentFileSizeAuthor
#1 608026-simpletest.js_.patch1.37 KBjohanneshahn
Screenshot.png16.61 KBMichaelCole

Comments

johanneshahn’s picture

johanneshahn commented
Assigned: Unassigned » johanneshahn
Status: Active » Needs review
StatusFileSize
new 608026-simpletest.js_.patch1.37 KB

quick fix in javascript with making checkbox ids lowercase.

reference php code simpletest.pages.inc near lline: 97

    // Make the class name safe for output on the page by replacing all
    // non-word/decimal characters with a dash (-).
    $test_class = strtolower(trim(preg_replace("/[^\w\d]/", "-", $key)));

   ....
   ....

    // Place-holder for checkboxes to select group of tests.
    $row[] = array('id' => $test_class, 'class' => array('simpletest-select-all'));

notice: $test_class is used as id name for checkboxes

Status: Needs review » Needs work

The last submitted patch failed testing.

c960657’s picture

c960657 commented
Status: Needs work » Closed (duplicate)

This is a duplicate of #598570: Test group checkboxs no longer select all groups tests.