Posted by effulgentsia on October 18, 2009 at 9:09pm
7 followers
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | theme system |
| Category: | task |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
| Issue tags: | RDF |
Issue Summary
My apologies. In #569362: Document $attributes, $title_attributes, and $content_attributes template variables, I don't know why, but I missed thinking through that $content_attributes would also be needed. Patch coming.
Comments
#1
It's really a no-brainer and I don't know how I missed it in the earlier issue. All the tpl file already have a div for the content, and that's the div that should be used for RDF attributes that describe the content of the entity as opposed to the entire entity. The current RDF patch gets around it by putting an extra div around the content where it needs it, but this way, we can remove redundant divs.
#2
Makes perfectly sense.
#3
#4
+1 from me too
#5
I confirm this solves the intended issue. already committed as part of #493030: RDF #1: core RDF module
EDIT: I meant included for now in the patch #493030: RDF #1: core RDF module until this is committed.
#6
Slight confusion about the term "committed", I guess.
#7
Looks good to me, committed to CVS HEAD. Thanks!
#8
Automatically closed -- issue fixed for 2 weeks with no activity.
#9
The patch #1 didn't cover user-profile.tpl.php. Tests included.
#10
fix documentation
#11
+++ modules/rdf/rdf.test@@ -187,4 +187,21 @@ class RdfMappingDefinitionTestCase extends DrupalWebTestCase {
+ function testAttributesInMarkup4() {
4?
+++ modules/rdf/rdf.test@@ -187,4 +187,21 @@ class RdfMappingDefinitionTestCase extends DrupalWebTestCase {
+ $this->assertTrue(!empty($user_profile_about), t('RDFa markup found on user profile page'));
+
+ }
Please remove this blank line.
Powered by Dreditor.
#12
addressed sun's review.
#13
Thanks!
#14
Yay! The first RDF patch I understand! ;)
Committed to HEAD.
#15
Automatically closed -- issue fixed for 2 weeks with no activity.