PHP Lint is trying to verify a JS file has correct PHP syntax. This causes the testbot to incorrectly fail it.

See issue: http://drupal.org/node/601952#comment-2140208

Patch attached here for posterity :-)

CommentFileSizeAuthor
601952_0.patch3.38 KBMichaelCole

Comments

boombatower’s picture

boombatower commented
Status: Active » Postponed (maintainer needs more info)

First line is before patch, second is after...no idea why that particular client decided to fail it. Perhaps a flawed PHP version?

boombatower@boomba:~/software/drupal-7/modules/field_ui> php -l field_ui.js
No syntax errors detected in field_ui.js
boombatower@boomba:~/software/drupal-7/modules/field_ui> php -l field_ui.js
No syntax errors detected in field_ui.js

I am running

PHP 5.2.9 with Suhosin-Patch 0.9.7 (cli) (built: Mar 12 2009 21:22:29)

We should check it out on bot, in mean time try resending patch.

boombatower’s picture

boombatower commented
Version: 6.x-1.x-dev » 6.x-2.x-dev
Assigned: Unassigned » boombatower
Status: Postponed (maintainer needs more info) » Fixed

Fixed in 2.x since this can occur (although I can't make it happen in this situation).

Should deploy in next two weeks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.