Posted by dalin on October 19, 2009 at 12:22am
| Project: | Devel |
| Version: | 7.x-1.x-dev |
| Component: | performance |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Currently the performance module displays its menu items to anyone with the 'access administration pages' perm. This means that on a big site content creators/editors will likely have access to the module settings. This patch creates a real permission called 'administer performance logging'.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| performance_logging_perms.diff | 2.59 KB | Idle | FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [:pserver:anonymous:anonymous@cvs.drupal.org:/cvs/drupal/drupal]. | View details |
Comments
#1
I like it. Can you create a patch for D7 as well?
#2
Here's a patch for D7. Almost byte-for-byte equivalent to the D6 version.
#3
The permissions hook changed in D7:
http://api.drupal.org/api/function/hook_permission/7
#4
Rerolled so that it now works.
This being done, I'm not too fond of using the same permission for "configure the module" and "access report". Wouldn't it be better to use the system-wide existing permission to "View site reports" from system.module ?
#5
Committed. Thank you both.
#6
Automatically closed -- issue fixed for 2 weeks with no activity.