Hi

Great module! Just upgraded to 1.1, and my excerpt textareas have grown! It seems that their size is now based on the body textarea's size? I'm sure that's really useful for some people, but in my situation the teaser's always going to be considerably shorter than the body. I've changed the code on my local installation, but it would be cool if there was an option to specify whether you want to set a manual size or to base it on the body's size.

Thanks,

Andy

CommentFileSizeAuthor
#6 excerpt.patch5.27 KBandyf

Comments

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented

Yes, it seemed reasonable to me to have it the same size as the body field. Let's see what others have to say about this.

I think you may be able to change the teaser size in your theme instead of changing your module's local installation. I think you may be able to change it via CSS or even JS, so you can keep the module unchanged for easy future upgrades.

Also, you could create another module to alter that size and give you the setting you need.

And finally, if you feel this is worth including it in the module, please feel free to submit a patch for this feature.

Thanks!

racakg’s picture

racakg commented

It would be good if you can setup option to set a manual size of excerpt textareas.

andyf’s picture

andyf commented

Thanks for the tips!

Don't have the skills (yet) to roll it into a module or a patch I'm afraid, but when my workload dies down a bit I'll start looking at Drupal development...

Thanks again,

Andy

charos’s picture

charos commented

I also would like to see a text area option and a character limit setting. I don't find any logic to have such a big text area for a teaser. Apart from that , it might confuse end users and starting writing the main body in excerpt.

andyf’s picture

andyf commented
Assigned: Unassigned » andyf

I'm happy to role this into a patch.

andyf’s picture

andyf commented
StatusFileSize
new excerpt.patch5.27 KB

Here's the patch. Visit the edit content type page and there's a textfield where you can set the size of the teaser in rows.

Also added a few one-liner fixes:

HTH, lemme know if any problems.

Thanks,

Andy

andyf’s picture

andyf commented
Status: Active » Needs review
charos’s picture

charos commented

Checked all fixes and seems to work as expected! Thanks for the patch !!!

jromine’s picture

jromine commented

Patch works fine. Thanks.

Hetta’s picture

Hetta commented
Status: Needs review » Reviewed & tested by the community

Patch works nicely, thanks!

agerson’s picture

agerson commented

works great!

andyf’s picture

andyf commented

Glad it works for folk. It doesn't look like there's anyone actively maintaining this module - I'll try and contact the official maintainers, see what the situation is.

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented

Maintainer of the module checking in. Just to let you guys know that I am maintaining the module (and some others), and I will review this one soon. I once started but got behind because of other more important issues. It appears that there's enough interest on this issue to be included.

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
Status: Reviewed & tested by the community » Fixed

Ok, committed. Thanks and sorry for the delay.

andyf’s picture

andyf commented

Thanks hanoii, much appreciated.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

westie’s picture

westie commented

I think this would be a great feature to include :)