Error with body display set to hidden [#608424]

Hi,
I have the following error when try to view a node:
Notice: Undefined index: body in locale_field_fallback_view() (line 71 of modules\locale\locale.field.inc).
I have:

Enabled locale.
Added a language (it).
Enabled the URL content language negotation.
Enabled the Multilingual support for the page content type.
Setted to hidden the full node display format for the body
Created a page with language en

Comment	File	Size	Author
#7	locale-608424-6.patch	4.18 KB	peximo
#6	locale-608424-6.patch	4.25 KB	peximo
#4	locale-608424-4.patch	3.87 KB	peximo
#1	locale-608424-1.patch	854 bytes	peximo

Comments

Comment #1

peximo commented 19 October 2009 at 15:31

Status	File	Size
new	locale-608424-1.patch	854 bytes

The problem is in locale_field_fallback_view() which only checks if a field is empty, not if it is set.

Comment #2

plach

he/him

Italian

Venezia

commented 19 October 2009 at 16:00

Status:

Active

» Needs review

let's test this

Comment #3

plach

he/him

Italian

Venezia

commented 19 October 2009 at 17:23

Status:

Needs review

» Needs work

The patch looks good, but multilingual field tests need to be updated.

Comment #4

peximo commented 20 October 2009 at 17:22

Status:

Needs work

» Needs review

Status	File	Size
new	locale-608424-4.patch	3.87 KB

Added some test.

Comment #5

plach

he/him

Italian

Venezia

commented 21 October 2009 at 09:50

Status:

Needs review

» Needs work

Also the new test looks good. A couple of minor issues:

+++ modules/locale/locale.test	20 Oct 2009 17:19:15 -0000
@@ -1691,6 +1690,40 @@ class LocaleMultilingualFieldsFunctional
+  /*
+   * Test if body field with hidden display is correctly not showed on node 
+   * view.
+   */

Better: "Test if the body field does not appear on node view when the "hidden" display is set for the "full" build mode."

+++ modules/locale/locale.test	20 Oct 2009 17:19:15 -0000
@@ -1691,6 +1690,40 @@ class LocaleMultilingualFieldsFunctional
+    // @todo: test if body full type is hidden

Should be "Test if the body display is actually "hidden" for the "full" build mode.". We might want to actually implement this before commit.

This review is powered by Dreditor.