Project:ecard
Version:6.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

The attached patch replaces the current implementation of %foo placeholders with those provided by the token module. It also
implements the token hooks to extend these with ecard specific tokens.

However, this patch may or may not dependent on #608684: split sending of ecards into an API call - I didn't re-roll it from a clean install, sorry.

Cheers,
Stella

AttachmentSize
ecard_tokens.patch10.67 KB

Comments

#1

Patch re-roll

AttachmentSize
608788.patch 10.67 KB

#2

Status:needs review» needs work

I have to apply this by hand. This may take a while.

The good side of the patch is that we use token! Yay!

The bad side is that we basically fork the module here because all old setting with %sitename won't work anymore. And the module will have to depend on token which is not in the current patch. I already wanted to make a really new version so with this patch I will make a new branch 6.x-2 so it doesn't get mixed up. Any Tweaks should go into this than.

#3

Status:needs work» fixed

#608788 by stella | Kars-T: Added add support for token module.

I did commit this to the 6.x-2.x branch. Thank you!

#4

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here