If I press “Clean environment” on admin/config/development/testing, and there are no leftover tables in the database, a PHP notice is triggered:

Notice: Undefined variable: ret in simpletest_clean_database() (line 425 of /home/chsc/www/drupal7/modules/simpletest/simpletest.module).

CommentFileSizeAuthor
simpletest-ret-1.patch1.46 KBc960657

Comments

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix
boombatower’s picture

boombatower commented

oo...I made issue at #610240: $ret left out to die in simpletest_clean_database(), marking as dup.

nkmani’s picture

nkmani
Primary language English
Location San Jose, CA
commented

Patch works and the notice message is gone after the patch.

matason’s picture

matason commented

Patch applied cleanly and fixed the error.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Sounds like we need tests for cleaning the database. I'm not sure if this is possible, though.

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Quick fix

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.