Menu admin page should say something when you save

webchick - October 20, 2009 - 03:23
Project:Drupal
Version:7.x-dev
Component:menu system
Category:bug report
Priority:minor
Assigned:sivaji
Status:needs review
Issue tags:Novice
Description

If you go to admin/structure/menu/manage/management, for example, and click the save button, you get no feedback that anything happened. A drupal_set_message() should display something generic like "Your configuration has been saved." Check what other places in core are doing for a hint.

#1

lisarex - November 2, 2009 - 01:44

#2

sivaji - November 27, 2009 - 11:53
Status:active» needs review

Attached patch provides appropriate status message when you add or edit a menu or menu item.

AttachmentSizeStatusTest resultOperations
609108_menu_admin_page_feedback.patch1.68 KBIdlePassed on all environments.View details | Re-test

#3

Dries - November 27, 2009 - 15:46

Can we simplify the message and make it consistent with #620592: Taxonomy admin page ... need feedback when saving?

#4

sivaji - November 27, 2009 - 16:05
Assigned to:Anonymous» sivaji
Status:needs review» needs work

That sounds good. I had the same thought when i am rolling this patch, but other status messages in the menu module is using something similar to "The new menu %name has been created". Anyways i will roll it again.

#5

sivaji - November 27, 2009 - 18:02

Attached patch simplifies the status message and makes it consistent with #620592: Taxonomy admin page ... need feedback when saving.

AttachmentSizeStatusTest resultOperations
609108_menu_admin_page_feedback.patch2.51 KBIdleFailed on MySQL 5.0 ISAM, with: 15,327 pass(es), 5 fail(s), and 0 exception(es).View details | Re-test

#6

sivaji - November 27, 2009 - 18:02
Status:needs work» needs review

#7

System Message - November 27, 2009 - 18:21
Status:needs review» needs work

The last submitted patch failed testing.

#8

sivaji - December 4, 2009 - 09:47
Status:needs work» needs review

Attached patch should work

AttachmentSizeStatusTest resultOperations
609108_menu_admin_page_feedback_1.patch4.06 KBIdlePassed on all environments.View details | Re-test

#9

System Message - December 4, 2009 - 10:01
Status:needs review» needs work

The last submitted patch failed testing.

#10

System Message - December 4, 2009 - 10:23
Status:needs work» needs review

sivaji requested that failed test be re-tested.

 
 

Drupal is a registered trademark of Dries Buytaert.