Download & Extend
Vote Up/Down » Issues

do not use empty links

Posted by garrettinteractive on October 20, 2009 at 12:28pm
Project:Vote Up/Down
Version:6.x-1.0-beta6
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (won't fix)

Issue Summary

On lines 622 and 640 of vote_up_down.module the actual link text is left blank with ' ' and does not have 'Vote up' or 'Vote down' respectively.

The module appears to degrade gracefully when a user turns off JS but not when they are not using the CSS such as a visually impaired user who is using JAWS for instance.

I'd propose to change lines 622 and 640 to:

Before:

      $variables['link1'] = l('', "vote_up_down/$type/$cid/1/$tag", array(

      $variables['link2'] =  l('', "vote_up_down/$type/$cid/-1/$tag", array(

After:

      $variables['link1'] = l('Vote up', "vote_up_down/$type/$cid/1/$tag", array(

      $variables['link2'] =  l('Vote down', "vote_up_down/$type/$cid/-1/$tag", array(

Any thoughts? Shall we roll this up into a patch?

Login or register to post comments

Comments

#1

Posted by marvil07 on June 8, 2010 at 8:33pm
Title:Accessibility Issue» do not use empty links
Category:support request» bug report

thanks for the report

#2

Posted by marvil07 on October 13, 2010 at 8:07pm
Status:active» closed (won't fix)

Since 6.x-1.x is not anymore maintained, I'm closing this.

Please note that this is fixed on 6.x-2.x.