Download & Extend
Login Destination » Issues

LD using undefined variables and assigning unused ones

Posted by fgm on October 20, 2009 at 2:04pm
Project:Login Destination
Version:6.x-2.3
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

At several places, login_destination.module was using possibly undefined array keys, or undefined variables.

And in login_destination_apply_redirect(), it computes a $destination but does not use it.

Patch takes care of these.

AttachmentSize
ld_variables.patch4.67 KB
Login or register to post comments

Comments

#1

Posted by rsvelko on October 21, 2009 at 12:11pm
Status:needs review» needs work

it has been commited to dev. Some parts are already in the latest 2.5 rel.

I have to re-read the code and trace it.

#2

Posted by rsvelko on February 14, 2010 at 1:11pm
Status:needs work» fixed

#3

Posted by System Message on February 28, 2010 at 1:20pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.