Patched against HEAD

CommentFileSizeAuthor
#7 eldir_fix.patch2.83 KBac
#5 eldir_one_column.patch1.77 KBac
page.png260 bytesac
eldir_style.patch825 bytesac
eldir_page.patch625 bytesac
eldir_info.patch512 bytesac

Comments

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work

I like this idea, just a couple things need fixing

1) the patch against the .css currently conflicts for some reason: possibly a newer change went in since and it doesn't like it. I manually fixed

2) remember that Hostmaster install profile will set at least one block in the left region that no longer exists, this will need fixing

3) the task block on the node view itself overlaps, see http://twitpic.com/mcedb/full

4) also seen in 3), the background image seems to have a 'hardcoded' :) vertical line where the other sidebar used to exist.

(edit: it was not obvious to me until acbot mentioned, that page.png needed to be downloaded and put into /images/ of eldir.. I thought it was meant to be a screenshot of what the patches do, and thought it was blank (didn't squint :) ) )

ac’s picture

ac
Primary language English
Location Perth
commented

RE 2) we can either include both sidebars in the single column or we can fix the install profile to not use the left sidebar. Up to you guys

adrian’s picture

adrian commented

put them both in one for now.

also , have you implemented the columns in the way i asked ? (ie: the remaining column is the width of 1 1/2 of the existing columns)

ac’s picture

ac
Primary language English
Location Perth
commented

k ill roll a patch for both in one.. yes column is 300px as opposed to 360px.

ac’s picture

ac
Primary language English
Location Perth
commented
StatusFileSize
new eldir_one_column.patch1.77 KB

Patch attached.. This is the only patch needed now, however you still need the page.png image from above in you eldir/images directory

ac’s picture

ac
Primary language English
Location Perth
commented
Status: Needs work » Needs review
ac’s picture

ac
Primary language English
Location Perth
commented
StatusFileSize
new eldir_fix.patch2.83 KB

new patch including hosting.css styles that were removed in #611976: General CSS cleanup

ac’s picture

ac
Primary language English
Location Perth
commented
Status: Needs review » Fixed

commited

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.