hook_node_access_records() doc is badly formatted

jhodgdon - October 20, 2009 - 23:40
Project:Drupal
Version:6.x-dev
Component:documentation
Category:bug report
Priority:minor
Assigned:Unassigned
Status:closed
Issue tags:Novice
Description

The return value section of the doc for hook_node_access_records() in D7 and D6 should be a bullet list for readability, but it isn't.
http://api.drupal.org/api/function/hook_node_access_records/7

#1

jhodgdon - October 20, 2009 - 23:41

Also, it references hook_node_grants(), but there are no () on the function name, which makes it not turn into a link.

#2

jhodgdon - October 22, 2009 - 14:59
Status:active» needs review

Here's a patch that cleans up the documentation for hook_node_grants(), and also the companion hook_node_access(). I think it makes more sense than the original.

If accepted, should also be ported to Drupal 6.

AttachmentSizeStatusTest resultOperations
610066.patch4.45 KBIdlePassed: 14439 passes, 0 fails, 0 exceptionsView details | Re-test

#3

Dries - October 24, 2009 - 11:49
Status:needs review» fixed

Committed to CVS HEAD. Thanks.

#4

jhodgdon - October 24, 2009 - 14:17
Version:7.x-dev» 6.x-dev
Status:fixed» patch (to be ported)

Needs port to Drupal 6.

#5

jhodgdon - October 26, 2009 - 23:19
Status:patch (to be ported)» fixed

These are in the contrib repository in Drupal 6, so I fixed directly there.
http://drupal.org/cvs?commit=280224

#6

System Message - November 9, 2009 - 23:20
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.