Menu and Block Quick Switch User Settings Don't Work for 'Anonymous'

Thanks for the patch. It looks like the patch needs to be re-rolled against the latest -dev release. For the most part, the method looks good. Comments follow:

+++ masquerade.module   21 Oct 2009 04:14:56 -0000
@@ -187,6 +187,9 @@
+         $u->name = variable_get('anonymous', t('Anonymous'));
+      }

The indentation needs to be fixed here.

+++ masquerade.module   21 Oct 2009 04:14:56 -0000
@@ -241,12 +245,29 @@
+ * Load users to accomodate for the anonymous 'user'

This line needs to end with a period. As well, parameters and return values need to be documented.

+++ masquerade.module   21 Oct 2009 04:14:56 -0000
@@ -241,12 +245,29 @@
+function _masquerade_user_load($username) {

The indentation needs to be fixed in this function - see http://drupal.org/coding-standards

+++ masquerade.module   21 Oct 2009 04:14:56 -0000
@@ -241,12 +245,29 @@
+  if ($username == '') {
+      return true;
+   }

Why do we return true here?

+++ masquerade.module   21 Oct 2009 04:14:56 -0000
@@ -241,12 +245,29 @@
+       $user = user_load(array('name' => ''));

Would it make more sense to do a user_load on uid=0?

+++ masquerade.module   21 Oct 2009 04:14:56 -0000
@@ -387,9 +414,10 @@
+        if( $switch_user == 0 ) {
+               $user_name->name = variable_get('anonymous', t('Anonymous'));
+            }

Fix indentation.

+++ masquerade.module   21 Oct 2009 04:14:56 -0000
@@ -502,6 +530,10 @@
+  //This will add anonymous to the list, but not sorted

Fix comment style.

+++ masquerade.module   21 Oct 2009 04:14:56 -0000
@@ -594,4 +626,4 @@
-}
+}

Not sure why there is a change here.

I'm on crack. Are you, too?

For some reason I had to manually apply the changes in masquerade_menu(). Also, on applying the patch, I got:

notice: Trying to get property of non-object in /Volumes/ECLIPSE/drupal6/sites/all/modules/masquerade/masquerade.module on line 66.

I've fixed both of these errors as well as fixing a similar issue in masquerade_block_0(). As well, I've modified _masquerade_user_load() to return FALSE, just like user_load(). When wrapping a core function, it's best to keep the return values as similar as possible. Let me know how it works / reviews for you.

FYI, the proper status would be Reviewed and Tested by the Community. "to be ported" is if the patch was to be backported to a previous Drupal version.

I've committed this patch.