Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.The installer fails in HEAD after choosing 'Hostmaster' as the install profile with this error:
Fatal error: Call to undefined function db_result() in /var/aegir/hostmaster-0.4-alpha2/includes/path.inc on line 55
It turns out that this is due to jquery_ui. It expects to find the jquery.ui library directory relative to its module dir:
/**
* Path to jQuery UI library.
*
* During site installation, JQUERY_UI_PATH is the absolute path to the
* jQuery UI library. At all other times JQUERY_UI_PATH is relative, and
* safe for use in URLs.
*/
if (defined('MAINTENANCE_MODE') && MAINTENANCE_MODE == 'install') {
define('JQUERY_UI_PATH', dirname(__FILE__) . '/jquery.ui');
}
else {
define('JQUERY_UI_PATH', drupal_get_path('module', 'jquery_ui') . '/jquery.ui');
}
our make file drops it into /profiles/hostmaster/libraries/jquery.ui
If you either move the library into jquery_ui/ , or edit the jquery_ui.module:
define('JQUERY_UI_PATH', '/var/aegir/hostmaster-0.4-alpha2/profiles/hostmaster/libraries/jquery.ui');
obviously it then works, and the installer can proceed.
I almost posted this in the jquery_ui issue queue :) as it seems like modules ought to support dropping stuff into the 'libraries' folder.
On the other hand, what do we do about it? Perhaps we should patch jquery_ui and retrieve/apply the patch since drush_make supports patches? What do you think?
Mig
Comments
Comment #1
Anonymous (not verified) commentedOr we drop the library into where jquery_ui expects it, by adding the destination to the make file.. but obviously we *want* to use the libraries dir for this
Comment #2
adrian commentedwe already set the destination.
Comment #3
Anonymous (not verified) commentedFixed in HEAD http://drupal.org/cvs?commit=277698
We were specifying
[download][destination], should just be[destination]Comment #4
Anonymous (not verified) commentedThis is happening again to me with a fresh HEAD install, although it is different to before:
Before, jquery.ui was getting downloaded into /profiles/hostmaster/libraries/jquery.ui
I changed
libraries[jquery_ui][download][destination] = "modules/jquery_ui"to belibraries[jquery_ui][destination] = "modules/jquery_ui"and it fixed it for me at the time.. I wonder if it fixed it while I was running drush 2.0 and the beta release of drush_make, and not HEAD of either.Now, with drush head and drush_make HEAD, it's getting downloaded into /var/aegir/ (pwd) , unzipped, not being renamed to jquery.ui, and not being moved anywhere.
Can someone please test a fresh HEAD install and see if the current state of hostmaster.make works for them when running
php /var/aegir/drush/drush.php hostmaster make $HOSTMASTER_DIRComment #5
Anonymous (not verified) commentedThis may really belong in the drush_make issue queue, I'm not sure.
I've just captured a full debug output of what happens when aegir.make's executed, so we can try and see why/where this is failing. Note the 'mv' errors when we get to jquery.ui library. everything else is ok, except for this part (and the usual smattering of drush_make errors)
http://www.mig5.net/sites/www.mig5.net/files/drush_make.log
We try and move the jquery.ui dir out of the tmp dir but we double-up the path to it
Comment #6
adrian commentedthis is related to drush_make , which we also need to get updated to make this release
tagging as such
Comment #7
adrian commentedthis is fixed in drush_make HEAD