Settings form isn't used which causes imageapi_jpeg_quality to be ignored.

Jax - October 21, 2009 - 12:36
Project:ImageAPI
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs work
Description

The imageapi_gd module has a settings form that is never displayed. When setting the jpeg quality it's the form generated by image_gd_settings() (in includes/image.gd.inc) that is displayed. This saves the jpeg quality level in image_jpeg_quality. Since the variable imageapi_jpeq_quality is never saved the default value is always used when saving an image.

I've removed the references to the imageapi_jpeq_quality variable and now use image_jpeg_quality.

AttachmentSize
imageapi.patch1.91 KB

#1

Jax - October 21, 2009 - 12:43
Status:active» needs review

Patch was attached for review.

#2

Jax - October 22, 2009 - 07:50
Status:needs review» needs work

When submitting the modules page it now complains: ImageAPI toolkit missing settings form. This needs more investigating.

 
 

Drupal is a registered trademark of Dries Buytaert.