Posted by Jax on October 21, 2009 at 12:36pm
Jump to:
| Project: | ImageAPI |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (won't fix) |
Issue Summary
The imageapi_gd module has a settings form that is never displayed. When setting the jpeg quality it's the form generated by image_gd_settings() (in includes/image.gd.inc) that is displayed. This saves the jpeg quality level in image_jpeg_quality. Since the variable imageapi_jpeq_quality is never saved the default value is always used when saving an image.
I've removed the references to the imageapi_jpeq_quality variable and now use image_jpeg_quality.
| Attachment | Size |
|---|---|
| imageapi.patch | 1.91 KB |
Comments
#1
Patch was attached for review.
#2
When submitting the modules page it now complains:
ImageAPI toolkit missing settings form. This needs more investigating.#3
I've noticed this also. Instead of removing variable refererence I have changed to desired quality directly in includes/image.gd.inc. The default 75% quality is horrible with it's blurry images.
#4
At least in the current versions the settings form is used. I'd prefer to have separate settings from core.