Closed (won't fix)
Project:
ImageAPI
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
21 Oct 2009 at 12:36 UTC
Updated:
17 Oct 2010 at 18:31 UTC
The imageapi_gd module has a settings form that is never displayed. When setting the jpeg quality it's the form generated by image_gd_settings() (in includes/image.gd.inc) that is displayed. This saves the jpeg quality level in image_jpeg_quality. Since the variable imageapi_jpeq_quality is never saved the default value is always used when saving an image.
I've removed the references to the imageapi_jpeq_quality variable and now use image_jpeg_quality.
| Comment | File | Size | Author |
|---|---|---|---|
| imageapi.patch | 1.91 KB | jax |
Comments
Comment #1
jax commentedPatch was attached for review.
Comment #2
jax commentedWhen submitting the modules page it now complains:
ImageAPI toolkit missing settings form. This needs more investigating.Comment #3
xalexas commentedI've noticed this also. Instead of removing variable refererence I have changed to desired quality directly in includes/image.gd.inc. The default 75% quality is horrible with it's blurry images.
Comment #4
drewish commentedAt least in the current versions the settings form is used. I'd prefer to have separate settings from core.