This patch introduced the following two lines of code in boost_stats.php, of which the second is clearly redundant:

  $q = (isset($_GET['qq']) && $_GET['qq'] != 'NULL') ? $_GET['qq'] : NULL;
  $q = (isset($_GET['q']) && $_GET['q'] != 'NULL') ? $_GET['q'] : NULL;

Since $q is wrong, it gets to save the wrong URL in the access log later.

simple patch attached.

CommentFileSizeAuthor
yh.patch882 bytesyhager

Comments

mikeytown2’s picture

mikeytown2 commented
Status: Needs review » Fixed

Thanks for finding and reporting this bug. I'm going to comment this out instead of removing, it's what should have happened in the first place.

yhager’s picture

yhager commented

cool.

I am working on backporting the stats functionality to Drupal 5.x, so that's how I found this issue. I hope to be able to provide a patch soon (assuming you still accept patches for 5.x).

mikeytown2’s picture

mikeytown2 commented

5.x should really be a back port of the current dev... if your serious about working with 5.x I can ask to get you CVS access so you can work on it. Most of the hard work in terms of developing new features & killing bugs is done, so back porting shouldn't be that difficult. I don't have any 5.x installs so I'm very reluctant about committing patches because I won't test them on a live server before doing a release. Drop me a line in this thread if your interested #454652: Looking for a co-maintainer - 5.x & feel free to post a patch, just letting you know that I don't commit 5.x code; but I'm sure others would benefit from it.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.