Facets requests for non-enabled modules

in d6 there is hook_disable

http://api.drupal.org/api/function/hook_disable/6

In cck, the modules do a hook_disable and then a content_notify().

Content_notify allows content.module to clean up. I don't think you need that much but maybe ...

http://api.lullabot.com/content_notify

Haven't tested but i like it

Index: apachesolr_search.module
===================================================================
--- apachesolr_search.module	(revision 5122)
+++ apachesolr_search.module	(working copy)
@@ -285,6 +285,10 @@
   $facet_missing = variable_get('apachesolr_facet_missing', array());
 
   foreach (apachesolr_get_enabled_facets() as $module => $module_facets) {
+    if (!module_exists($module)) {
+      // When modules are disabled their facet settings may remain.
+      continue;
+    }
     foreach($module_facets as $delta => $facet_field) {
       // TODO: generalize handling of date and range facets.
       if ($module == 'apachesolr_search' && ($facet_field == 'created' || $facet_field == 'changed')) {

Positive you need that hunk?

Code looks good, need to actually install OG and try it out =)

It works:

Before the patch:

With OG and apachesolr_og enabled, and the group filter enabled, a search request to Solr includes facet.field=im_og_gid
If the apachesolr_og module is then disabled, the search request still includes it.

After the patch:
When disabling the apachesolr_og module, the Solr request no longer includes that facet.

One caveat:
With the patch, when re-enabling apachesolr_og, one has to go to the "Enabled filters" tab and enable the OG facet again.
Is this expected behavior? If not a simple drupal_set_message() to the admin when disabling apachesolr_og could suffice =)

Patch for DRUPAL-5--2.

Committed to 5.x-2.x.

#610656 by pwolanin, claudiu.cristea | Scott Reynolds: Fixed Facets requests for non-enabled modules.

Now in Drupal 6.x-2.x as well.