Optionally skip hook_context_page_condition() for performance [#610724]

Comment	File	Size	Author
#3	context-n610724-v2.patch	1.06 KB	damienmckenna
#1	context-n610724.patch	1.06 KB	damienmckenna

Comment #1

damienmckenna

TN, USA

commented 21 October 2009 at 16:35

Status:

Active

» Needs review

Status	File	Size
new	context-n610724.patch	1.06 KB

Here's an initial patch that just adds a variable 'context_skip_hook_page_condition' which controls whether context_context_page_condition() is executed.

Log in or register to post comments

Comment #2

damienmckenna

TN, USA

commented 21 October 2009 at 16:36

FYI one use case where this is useful is for sites that don't use the core menu system to control their navigation, so spending time to process menu_get_active_trail() is redundant.

Log in or register to post comments

Comment #3

damienmckenna

TN, USA

commented 21 October 2009 at 16:37

Status	File	Size
new	context-n610724-v2.patch	1.06 KB

Updated patch.

Log in or register to post comments

Comment #4

yhahn commented 9 February 2010 at 06:07

Status:

Needs review

» Postponed (maintainer needs more info)

I'd like to know a little more about where you're seeing a performance hit here... menu_get_active_trail() retrieves a static cache and is called by menu_get_active_breadcrumb() and sometimes drupal_get_title(). These are both called from template_preprocess_page() so unless a theme is flying solo in the preprocess page stack these functions will get called.