Closed (fixed)
Project:
Nagios Monitoring
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
21 Oct 2009 at 18:17 UTC
Updated:
19 Sep 2011 at 13:16 UTC
Jump to comment: Most recent file
Comments
Comment #1
rfayThanks for the excellent module. I deployed it without a hitch.
I do want to exclude notifications of potential module updates. I don't want a "warning" every time a new dev version is available for some module. I really only want to know about security updates anyway.
Thanks again,
-Randy
Comment #2
freakalis commentedI also wanted to exclude some severities. I only wanted the critical ones like Cron not runt, Security updates and so on.
Here is a patch that lets you select a minium severity report level on the settings page. If you set it to critical you will only be notified when there are critical warnings.
Comment #3
kbahey commentedCommitted, and should be in the tarball in about 3 or so hours.
Please test it again.
P.S. I changed the wording (not only cron), and code style a bit.
Comment #5
coderintherye commentedFirst of all apologies if you want patches against 6, in which case I can make one there.
I believe the above patch works fine for the nagios page, but doesn't actually do anything for when the nagios check is invoked via drush since it invokes the functions directly.
The attached patch just adds two lines to check the minimum report severity within the nagios_check_requirements() function.
I may be taking the wrong approach here, but it's how I would expect/want it to work, but feel free to let me know if this is the wrong direction. Cheers.
Comment #6
greg.harveySeems sensible to me. Patches against Drupal 7 are fine and I can easily backport two lines, so don't worry. ;-)
Thanks!
Ps - for future reference, would've preferred a new bug report called something like "drush checks ignore minimum severity settings" - it's really a new issue, not an extension of this old one. But that's just me being pedantic. ;-)
Comment #7
coderintherye commentedCool thanks for taking it and in the future I'll be sure to file a new issue, just didn't want to clutter your queue. Cheers.
Comment #8
greg.harveyCommitted to Drupal 6 branch, still needs rolling for Drupal 7.
Comment #9
greg.harveyMarking.
Comment #10
greg.harveyNo, I'm talking rubbish, the port is done already... sorry for the noise! =)
Comment #11
greg.harveyThis is now done in both branches. Thanks!