In the drupal status report, there are certain informational messages which are reported as warnings. Two examples: the GD Image Filtering and Upload Progress status items. It would be very useful to optionally be able to configure the nagios module to ignore certain warnings when it is not possible to change them.

Comments

rfay’s picture

Thanks for the excellent module. I deployed it without a hitch.

I do want to exclude notifications of potential module updates. I don't want a "warning" every time a new dev version is available for some module. I really only want to know about security updates anyway.

Thanks again,
-Randy

freakalis’s picture

Status: Active » Needs review
StatusFileSize
new2.08 KB

I also wanted to exclude some severities. I only wanted the critical ones like Cron not runt, Security updates and so on.

Here is a patch that lets you select a minium severity report level on the settings page. If you set it to critical you will only be notified when there are critical warnings.

kbahey’s picture

Status: Needs review » Fixed

Committed, and should be in the tarball in about 3 or so hours.

Please test it again.

P.S. I changed the wording (not only cron), and code style a bit.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

coderintherye’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Closed (fixed) » Needs review
StatusFileSize
new896 bytes

First of all apologies if you want patches against 6, in which case I can make one there.

I believe the above patch works fine for the nagios page, but doesn't actually do anything for when the nagios check is invoked via drush since it invokes the functions directly.

The attached patch just adds two lines to check the minimum report severity within the nagios_check_requirements() function.

I may be taking the wrong approach here, but it's how I would expect/want it to work, but feel free to let me know if this is the wrong direction. Cheers.

greg.harvey’s picture

Status: Needs review » Reviewed & tested by the community

Seems sensible to me. Patches against Drupal 7 are fine and I can easily backport two lines, so don't worry. ;-)

Thanks!

Ps - for future reference, would've preferred a new bug report called something like "drush checks ignore minimum severity settings" - it's really a new issue, not an extension of this old one. But that's just me being pedantic. ;-)

coderintherye’s picture

Cool thanks for taking it and in the future I'll be sure to file a new issue, just didn't want to clutter your queue. Cheers.

greg.harvey’s picture

Committed to Drupal 6 branch, still needs rolling for Drupal 7.

greg.harvey’s picture

Status: Reviewed & tested by the community » Patch (to be ported)

Marking.

greg.harvey’s picture

Status: Patch (to be ported) » Reviewed & tested by the community

No, I'm talking rubbish, the port is done already... sorry for the noise! =)

greg.harvey’s picture

Status: Reviewed & tested by the community » Closed (fixed)

This is now done in both branches. Thanks!