Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.file_build_uri() uses the variable name file_scheme_default — it should have been file_default_scheme instead. The former is not used anywhere else in core.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | file_build_uri-2.patch | 5.8 KB | c960657 |
| file_build_uri-1.patch | 966 bytes | c960657 |
Comments
Comment #1
dries commentedIt looks like we have a hole in our test coverage here so marking 'code needs tests'.
Comment #2
jim0203 commentedIn any event, this reviews fine. file_scheme_default is not a valid variable; the one that is required here is file_default_scheme. Pass.
Comment #3
c960657 commentedAdded some tests.
Comment #4
dries commentedThanks for writing some extra tests! Committed to CVS HEAD. :)