Title says it all, but an image says even more: see the attached image.

I edited an existing node and re-inserted an image using Insert, to ensure it generates the exact same HTML as FileField Insert. Unfortunately there seems to be this tiny bug.

Comments

quicksketch’s picture

Thanks Wim, I had this occurring before I release Insert module, but I thought I had it corrected. This is probably a configuration I didn't test. Let me guess you have:

- An imagefield on which Insert is enabled.
- The imagefield does not have an alt or title field enabled.

I think I only tested it on an imagefield that did have both alt and title.

quicksketch’s picture

Status: Active » Needs review
StatusFileSize
new746 bytes

I think this patch should correct the problem.

quicksketch’s picture

Status: Needs review » Fixed

Yep, I reproduced this problem by disabling alt/title fields. The above patch corrects the problem and I've committed it.

wim leers’s picture

Your guesses were correct! And thanks for the fix :)

wim leers’s picture

Status: Fixed » Active

And I didn't notice this, but apparently the generated URLs are now absolute instead of relative? I don't mind. Just mentioning this changed behavior. This can also be seen in the screenshot I posted.

Feel free to mark as fixed again :)

quicksketch’s picture

Status: Active » Fixed

Yes the URLs are now absolute per #521812: relative path or full path settings. Basically full URLs are much more useful than relative ones for RSS feeds and aggregated content, even if they're less compatible between dev/live. I'd recommend Pathologic if that's a problem, but absolute URLs I think give the better "out-of-box" experience.

wim leers’s picture

Ok, thanks for the follow-up!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.