events for which notifications should be triggered: update, comment
rewe - October 22, 2009 - 07:54
| Project: | Notifications |
| Version: | 6.x-2.1 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | postponed (maintainer needs more info) |
Description
In "Notifications Settings" - "Events":
Although "Node update" is unchecked, notifications are sent out when an existing comment is updated ("Node comment" is checked).
On second thought this might even be intended behaviour since a comment is not a node - If so, I think it should be changed anyway so that when node updates are not supposed to trigger notifications this should be true for comment updates as well.
#1
Well, yes and no.
Notifications should only be sent when comments are posted / approved, this is independent of "node updates".
So, when comment is edited, is it being approved too (published)?
#2
In my case comments don't need to be approved - they are published immediately. Obviously when editing a comment, it is also approved immediately ... and that event used to trigger notifications as mentioned above. I applied the attached patch as a quick fix.