"I agree with these terms" checkbox is in the string but is not translated... strange.

CommentFileSizeAuthor
#3 terms_of_use-t_wrap_variable_get.patch3.09 KBgagarine

Comments

gagarine’s picture

gagarine commented
Status: Active » Needs review

Mmmh
I think is because on ligne 153

  $checkbox_label = check_plain(variable_get('terms_of_use_checkbox_label', t('I agree with these terms.')));

Need to be

  $checkbox_label = check_plain(t(variable_get('terms_of_use_checkbox_label', 'I agree with these terms.')));
gagarine’s picture

gagarine commented
Status: Needs review » Reviewed & tested by the community

Ok it test and it work.

gagarine’s picture

gagarine commented
Title: "I agree with these terms" checkbox is not translated » String is untranslatable: variable_get need to be wrapped by t function
Status: Reviewed & tested by the community » Patch (to be ported)
StatusFileSize
new terms_of_use-t_wrap_variable_get.patch3.09 KB

I found other string untranslatable and create a patch..

kars-t’s picture

kars-t commented
Status: Patch (to be ported) » Closed (duplicate)

Hi gagarine,

thanks for your work but you must not use t() like this!
http://groups.drupal.org/node/15177

This has to be done by tt()
http://drupal.org/node/304002

And this issue is a duplicate of #299416: translations support

Please don't set your own patches to "reviewed" or "to be ported". A review has to be done by somebody else and to be ported is something a mainter should use.

gagarine’s picture

gagarine commented

Thanks you I learn something today :)