String is untranslatable: variable_get need to be wrapped by t function
gagarine - October 22, 2009 - 10:19
| Project: | Terms of Use |
| Version: | 6.x-1.9 |
| Component: | User interface |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | duplicate |
Description
"I agree with these terms" checkbox is in the string but is not translated... strange.
#1
Mmmh
I think is because on ligne 153
<?php$checkbox_label = check_plain(variable_get('terms_of_use_checkbox_label', t('I agree with these terms.')));
?>
Need to be
<?php$checkbox_label = check_plain(t(variable_get('terms_of_use_checkbox_label', 'I agree with these terms.')));
?>
#2
Ok it test and it work.
#3
I found other string untranslatable and create a patch..
#4
Hi gagarine,
thanks for your work but you must not use t() like this!
http://groups.drupal.org/node/15177
This has to be done by tt()
http://drupal.org/node/304002
And this issue is a duplicate of #299416: translations support
Please don't set your own patches to "reviewed" or "to be ported". A review has to be done by somebody else and to be ported is something a mainter should use.
#5
Thanks you I learn something today :)